minor update for MSSQL --tables (fallback to other method)

stamparm · stamparm · commit f412706fee32 · 2012-01-03T18:01:14.000Z
diff --git a/plugins/dbms/mssqlserver/enumeration.py b/plugins/dbms/mssqlserver/enumeration.py
@@ -93,8 +93,11 @@ def getTables(self):
 
                     continue
 
-                query = rootQuery.inband.query.replace("%s", db)
-                value = inject.getValue(query, blind=False)
+                for query in (rootQuery.inband.query, rootQuery.inband.query2):
+                    query = query.replace("%s", db)
+                    value = inject.getValue(query, blind=False)
+                    if not isNoneValue(value):
+                        break
 
                 if not isNoneValue(value):
                     kb.data.cachedTables[db] = arrayizeValue(value)
diff --git a/plugins/generic/enumeration.py b/plugins/generic/enumeration.py
@@ -887,9 +887,6 @@ def getTables(self, bruteForce=None):
                 if len(dbs) < 2 and ("%s," % condition) in query:
                     query = query.replace("%s," % condition, "", 1)
 
-            if Backend.isDbms(DBMS.MSSQL):
-                query = safeStringFormat(query, conf.db)
-
             value = inject.getValue(query, blind=False)
 
             if not isNoneValue(value):
diff --git a/xml/queries.xml b/xml/queries.xml
@@ -184,7 +184,7 @@
             <blind query="SELECT TOP 1 name FROM master..sysdatabases WHERE name NOT IN (SELECT TOP %d name FROM master..sysdatabases ORDER BY name) ORDER BY name" count="SELECT LTRIM(STR(COUNT(name))) FROM master..sysdatabases"/>
         </dbs>
         <tables>
-            <inband query="SELECT %s..sysusers.name+'.'+%s..sysobjects.name FROM %s..sysobjects INNER JOIN %s..sysusers ON %s..sysobjects.uid = %s..sysusers.uid WHERE xtype IN ('u', 'v')"/>
+            <inband query="SELECT %s..sysusers.name+'.'+%s..sysobjects.name FROM %s..sysobjects INNER JOIN %s..sysusers ON %s..sysobjects.uid = %s..sysusers.uid WHERE xtype IN ('u', 'v')" query2="SELECT table_schema+'.'+table_name FROM information_schema.tables WHERE table_catalog='%s'"/>
             <blind query="SELECT TOP 1 %s..sysusers.name+'.'+%s..sysobjects.name FROM %s..sysobjects INNER JOIN %s..sysusers ON %s..sysobjects.uid = %s..sysusers.uid WHERE xtype IN ('u', 'v') AND %s..sysusers.name+'.'+%s..sysobjects.name NOT IN (SELECT TOP %d %s..sysusers.name+'.'+%s..sysobjects.name FROM %s..sysobjects INNER JOIN %s..sysusers ON %s..sysobjects.uid = %s..sysusers.uid WHERE xtype IN ('u', 'v') ORDER BY %s..sysusers.name+'.'+%s..sysobjects.name) ORDER BY %s..sysusers.name+'.'+%s..sysobjects.name" count="SELECT LTRIM(STR(COUNT(name))) FROM %s..sysobjects WHERE xtype IN ('u','v')"/>
         </tables>
         <columns>
