lint

lzchen · lzchen · commit 778223e52f10 · 2020-07-07T16:16:22.000-07:00
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/aggregate.py b/opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/aggregate.py
@@ -148,6 +148,7 @@ def __init__(self, config=None):
         self.current[">"] = 0
         self.checkpoint[">"] = 0
 
+    # pylint: disable=R0201
     def _validate_boundaries(self, boundaries):
         if not boundaries:
             logger.warning("Bounds is empty. Using default.")
@@ -273,6 +274,7 @@ def get_latest_timestamp(time_stamp, other_timestamp):
     return time_stamp
 
 
+# pylint: disable=R1705
 def verify_type(this, other):
     if isinstance(other, this.__class__):
         return True
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/batcher.py b/opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/batcher.py
@@ -40,6 +40,7 @@ def checkpoint_set(self) -> Sequence[MetricRecord]:
         data in all of the aggregators in this batcher.
         """
         metric_records = []
+        # pylint: disable=W0612
         for (
             (instrument, aggregator_type, labels),
             aggregator,
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/metrics/view.py b/opentelemetry-sdk/src/opentelemetry/sdk/metrics/view.py
@@ -15,7 +15,7 @@
 import logging
 import threading
 from collections import defaultdict
-from typing import Sequence, Tuple, Type
+from typing import Sequence, Tuple
 
 from opentelemetry.metrics import (
     Counter,
diff --git a/opentelemetry-sdk/tests/metrics/test_metrics.py b/opentelemetry-sdk/tests/metrics/test_metrics.py
@@ -486,6 +486,7 @@ def test_run_exception(self, logger_mock):
         self.assertTrue(logger_mock.warning.called)
 
 
+# pylint: disable=no-self-use
 class TestBoundCounter(unittest.TestCase):
     def test_add(self):
         meter_mock = mock.Mock()
diff --git a/opentelemetry-sdk/tests/metrics/test_view.py b/opentelemetry-sdk/tests/metrics/test_view.py
@@ -75,5 +75,6 @@ def test_default_aggregator(self, logger_mock):
 
 
 class DummyMetric(metrics.Metric):
+    # pylint: disable=W0231
     def __init__(self):
         pass
