Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 787c8db

Browse files
committed
Keep User-Agent header up to date
1 parent eeb6b42 commit 787c8db

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
[#399](https://github.com/phadej/github/pull/399)
55
- Make File.fileSha optional
66
[#392](https://github.com/phadej/github/pull/392)
7+
- Update User-Agent to contain up to date version
8+
[#403](https://github.com/phadej/github/pull/403)
9+
[#394](https://github.com/phadej/github/pull/394)
710

811
## Changes for 0.22
912

github.cabal

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,8 @@ library
154154
GitHub.Internal.Prelude
155155
GitHub.Request
156156

157+
other-modules: Paths_github
158+
157159
-- Packages bundles with GHC, mtl and text are also here
158160
build-depends:
159161
base >=4.7 && <4.14

src/GitHub/Request.hs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,9 @@ import Control.Monad.Trans.Class (lift)
6868
import Control.Monad.Trans.Except (ExceptT (..), runExceptT)
6969
import Data.Aeson (eitherDecode)
7070
import Data.List (find)
71+
import Data.String (fromString)
7172
import Data.Tagged (Tagged (..))
73+
import Data.Version (showVersion)
7274

7375
import Network.HTTP.Client
7476
(HttpException (..), Manager, RequestBody (..), Response (..), getUri,
@@ -88,11 +90,11 @@ import qualified Network.HTTP.Client as HTTP
8890
import qualified Network.HTTP.Client.Internal as HTTP
8991

9092
#ifdef MIN_VERSION_http_client_tls
91-
import Network.HTTP.Client.TLS (tlsManagerSettings)
93+
import Network.HTTP.Client.TLS (tlsManagerSettings)
9294
#else
9395
import Network.HTTP.Client.OpenSSL (opensslManagerSettings, withOpenSSL)
9496

95-
import qualified OpenSSL.Session as SSL
97+
import qualified OpenSSL.Session as SSL
9698
import qualified OpenSSL.X509.SystemStore as SSL
9799
#endif
98100

@@ -101,6 +103,8 @@ import GitHub.Data (Error (..))
101103
import GitHub.Data.PullRequests (MergeResult (..))
102104
import GitHub.Data.Request
103105

106+
import Paths_github (version)
107+
104108
#ifdef MIN_VERSION_http_client_tls
105109
withOpenSSL :: IO a -> IO a
106110
withOpenSSL = id
@@ -418,7 +422,7 @@ makeHttpRequest auth r = case r of
418422
setMethod m req = req { method = m }
419423

420424
reqHeaders :: RequestHeaders
421-
reqHeaders = [("User-Agent", "github.hs/0.21")] -- Version
425+
reqHeaders = [("User-Agent", "github.hs/" <> fromString (showVersion version))] -- Version
422426
<> [("Accept", unTagged (contentType :: Tagged mt BS.ByteString))]
423427

424428
setBody :: LBS.ByteString -> HTTP.Request -> HTTP.Request

0 commit comments

Comments
 (0)