Merge pull request haskell-github#429 from vrom911/vrom911/428-edit-issue-number

phadej · web-flow · commit ce8ece7d29a9 · 2020-02-11T16:17:39.000+02:00
Use IssueNumber in editIssueR and issueR
diff --git a/spec/GitHub/IssuesSpec.hs b/spec/GitHub/IssuesSpec.hs
@@ -38,6 +38,11 @@ spec = do
                   cms <- GitHub.executeRequest auth $
                     GitHub.commentsR owner repo (GitHub.issueNumber i) 1
                   cms `shouldSatisfy` isRight
+    describe "issueR" $ do
+        it "fetches issue #428" $ withAuth $ \auth -> do
+            resIss <- GitHub.executeRequest auth $
+                GitHub.issueR "phadej" "github" (GitHub.IssueNumber 428)
+            resIss `shouldSatisfy` isRight
   where
     repos =
       [ ("thoughtbot", "paperclip")
diff --git a/src/GitHub/Endpoints/Issues.hs b/src/GitHub/Endpoints/Issues.hs
@@ -33,7 +33,7 @@ organizationIssuesR org opts =
 
 -- | Query a single issue.
 -- See <https://developer.github.com/v3/issues/#get-a-single-issue>
-issueR :: Name Owner -> Name Repo -> Id Issue -> Request k Issue
+issueR :: Name Owner -> Name Repo -> IssueNumber -> Request k Issue
 issueR user reqRepoName reqIssueNumber =
     query ["repos", toPathPart user, toPathPart reqRepoName, "issues", toPathPart reqIssueNumber] []
 
@@ -63,6 +63,6 @@ editOfIssue = EditIssue Nothing Nothing Nothing Nothing Nothing Nothing
 
 -- | Edit an issue.
 -- See <https://developer.github.com/v3/issues/#edit-an-issue>
-editIssueR :: Name Owner -> Name Repo -> Id Issue -> EditIssue -> Request 'RW Issue
+editIssueR :: Name Owner -> Name Repo -> IssueNumber -> EditIssue -> Request 'RW Issue
 editIssueR user repo iss =
     command Patch ["repos", toPathPart user, toPathPart repo, "issues", toPathPart iss] . encode
