use {} instead of dict() (open-telemetry#2133)

alrex · web-flow · commit a2c7c20f6945 · 2021-09-20T05:06:59.000+05:30
* use {} instead of dict()

* fix lint
diff --git a/opentelemetry-api/tests/attributes/test_attributes.py b/opentelemetry-api/tests/attributes/test_attributes.py
@@ -43,10 +43,10 @@ def test_attribute_key_validation(self):
 
     def test_clean_attribute(self):
         self.assertInvalid([1, 2, 3.4, "ss", 4])
-        self.assertInvalid([dict(), 1, 2, 3.4, 4])
+        self.assertInvalid([{}, 1, 2, 3.4, 4])
         self.assertInvalid(["sw", "lf", 3.4, "ss"])
         self.assertInvalid([1, 2, 3.4, 5])
-        self.assertInvalid(dict())
+        self.assertInvalid({})
         self.assertInvalid([1, True])
         self.assertValid(True)
         self.assertValid("hi")
diff --git a/opentelemetry-sdk/tests/resources/test_resources.py b/opentelemetry-sdk/tests/resources/test_resources.py
@@ -213,7 +213,7 @@ def test_invalid_resource_attribute_values(self):
         resource = resources.Resource(
             {
                 resources.SERVICE_NAME: "test",
-                "non-primitive-data-type": dict(),
+                "non-primitive-data-type": {},
                 "invalid-byte-type-attribute": b"\xd8\xe1\xb7\xeb\xa8\xe5 \xd2\xb7\xe1",
                 "": "empty-key-value",
                 None: "null-key-value",
diff --git a/opentelemetry-sdk/tests/trace/test_sampling.py b/opentelemetry-sdk/tests/trace/test_sampling.py
@@ -50,7 +50,7 @@ def test_is_sampled(self):
 class TestSamplingResult(unittest.TestCase):
     def test_ctr(self):
         attributes = {"asd": "test"}
-        trace_state = dict()
+        trace_state = {}
         # pylint: disable=E1137
         trace_state["test"] = "123"
         result = sampling.SamplingResult(
diff --git a/opentelemetry-sdk/tests/trace/test_trace.py b/opentelemetry-sdk/tests/trace/test_trace.py
@@ -637,10 +637,10 @@ def test_attributes(self):
     def test_invalid_attribute_values(self):
         with self.tracer.start_as_current_span("root") as root:
             root.set_attributes(
-                {"correct-value": "foo", "non-primitive-data-type": dict()}
+                {"correct-value": "foo", "non-primitive-data-type": {}}
             )
 
-            root.set_attribute("non-primitive-data-type", dict())
+            root.set_attribute("non-primitive-data-type", {})
             root.set_attribute(
                 "list-of-mixed-data-types-numeric-first",
                 [123, False, "string"],
@@ -649,9 +649,7 @@ def test_invalid_attribute_values(self):
                 "list-of-mixed-data-types-non-numeric-first",
                 [False, 123, "string"],
             )
-            root.set_attribute(
-                "list-with-non-primitive-data-type", [dict(), 123]
-            )
+            root.set_attribute("list-with-non-primitive-data-type", [{}, 123])
             root.set_attribute("list-with-numeric-and-bool", [1, True])
 
             root.set_attribute("", 123)
@@ -772,9 +770,9 @@ def test_invalid_event_attributes(self):
 
         with self.tracer.start_as_current_span("root") as root:
             root.add_event("event0", {"attr1": True, "attr2": ["hi", False]})
-            root.add_event("event0", {"attr1": dict()})
+            root.add_event("event0", {"attr1": {}})
             root.add_event("event0", {"attr1": [[True]]})
-            root.add_event("event0", {"attr1": [dict()], "attr2": [1, 2]})
+            root.add_event("event0", {"attr1": [{}], "attr2": [1, 2]})
 
             self.assertEqual(len(root.events), 4)
             self.assertEqual(root.events[0].attributes, {"attr1": True})

Original file line number	Diff line number	Diff line change
`@@ -213,7 +213,7 @@ def test_invalid_resource_attribute_values(self):`
`213`	`213`	`resource = resources.Resource(`
`214`	`214`	`{`
`215`	`215`	`resources.SERVICE_NAME: "test",`
`216`		`- "non-primitive-data-type": dict(),`
	`216`	`+ "non-primitive-data-type": {},`
`217`	`217`	`"invalid-byte-type-attribute": b"\xd8\xe1\xb7\xeb\xa8\xe5 \xd2\xb7\xe1",`
`218`	`218`	`"": "empty-key-value",`
`219`	`219`	`None: "null-key-value",`