Adds key function to binarysearch.js

Dan Kaplun · Dan Kaplun · commit 8828b848f456 · 2015-01-15T13:48:58.000-06:00
If an element is not found, return -x - 1 where x is the index into which the element should be inserted Closes mgechev#36
diff --git a/src/searching/binarysearch.js b/src/searching/binarysearch.js
@@ -18,22 +18,27 @@
    * @param {Number} value Value of the element which index should be found.
    * @returns {Number} Index of the element or -1 if not found.
    */
-  function binarySearch(array, value) {
+  function binarySearch(array, value, key) {
+    key = !key ? id : typeof key === 'string' ? get(key) : key;
+    value = key(value);
     var middle = Math.floor(array.length / 2);
     var left = 0;
     var right = array.length;
     while (right >= left) {
-      if (array[middle] === value) {
+      var middleValue = key(array[middle]);
+      if (middleValue === value) {
         return middle;
-      } else if (array[middle] > value) {
+      } else if (middleValue > value) {
         right = middle - 1;
       } else {
         left = middle + 1;
       }
       middle = Math.floor((left + right) / 2);
     }
-    return -1;
+    return -middle - 1;
   }
+  function id (val) { return val; }
+  function get (key) { return function (val) { return val[key]; }; }
 
   exports.binarySearch = binarySearch;
 
diff --git a/test/searching/binarysearch.spec.js b/test/searching/binarysearch.spec.js
@@ -18,11 +18,19 @@ describe('Binary search', function () {
     expect(binarySearch([1, 8], 8)).toBe(1);
   });
 
-  it('should return -1 for missing elements', function () {
-    expect(binarySearch([1, 2, 3], 4)).toBe(-1);
+  it('should return a negative number for missing elements', function () {
+    expect(binarySearch([1, 2, 3], 4)).toBeLessThan(0);
   });
 
   it('should work with empty arrays', function () {
     expect(binarySearch([], 4)).toBe(-1);
   });
+
+  it('should work with a key string', function () {
+    expect(binarySearch([{ x: 1 }, { x: 2 }, { x: 3 }], { x: 2 }, 'x')).toBe(1);
+  });
+
+  it('should work with a key function', function () {
+    expect(binarySearch([{ x: 1 }, { x: 2 }, { x: 3 }], { x: 2 }, function (o) { return o.x; })).toBe(1);
+  });
 });
