Yeah ill merge it, maybe have some nits for you but this is good!

/review

Do we need the dynamic import for mcp?

also I wonder if instead of this pattern we should expose ways to add/remove commands on the command namespace and then mcp can just add slash commands / remove them through that?

We kinda have a similar thing for MCP

this is me just glancing over but it's just the way the domains overlap so curious your opinion

Do we need the dynamic import for mcp?

In case we don't have any MCP the slash command will always be a normal command. With the dynamic import we will avoid importing the module all together. Not necessary and I'm willing to refactor but seems like a nice addition

also I wonder if instead of this pattern we should expose ways to add/remove commands on the command namespace and then mcp can just add slash commands / remove them through that?

We kinda have a similar thing for MCP

this is me just glancing over but it's just the way the domains overlap so curious your opinion

We could also do that but it would still require custom logic because the template of the prompt is "special". But yeah I guess it's just a matter of who owns what. You definitely have more experience in the codebase so up to you to take the call. Just let me know and I'll refactor it eventually.

@rekram1-node shouln not have trusted the review 😅 I actually removed the snake_case now without type errors

@rekram1-node @paoloricciuti i've tested the original pr against basicmemory and it worked great so far. dependent on an mcp server properly handling prompts in terms of error handling but thats not the problem of the pr implementation. this and getting resources in would be amazing.

@kziemski glad to hear... I'm gonna work on resources immediately after this gets merged

planning to merge today

Btw I think I have the resource PR basically ready... I'll wait anyway, so this doesn't become a huge PR and there will be fewer conflicts.

@rekram1-node Just realized: should I also update the documentation?

merging this today for sure, think I may tweak it a bit but thanks!

i lied lol but I will merge today promise, getting back from lunch now then going to pull this down and play w/ it

Okay found some bugs, when I do this w/ svelte mcp prompt and don't pass args it just craps out and gets stuck in loading state

Uh interesting! Which bugs did you found? Can I do something?

Edit: uh saw the edit...did you fix it? I can do it otherwise... I'd say we just send empty arguments in case...WDYT?