-
Notifications
You must be signed in to change notification settings - Fork 24
Add support for Patch endpoints #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ch into patch_endpoints
…ch into patch_endpoints
…ch into patch_endpoints
@jonhealy1 this is ready for review but is pinned to a pull request for |
@rhysrevans3 Adding patch endpoints is pretty epic. |
One thing to note. Anything elasticsearch-related from core needs to be moved to sfeos_helpers now. Sorry for doing this in the middle of this work. Core now is only for code that is database-agnostic and may be useful for other databases besides for just es/os. Some of the shared code from database_logic in elasticsearch and opensearch could also theoretically be moved to sfeos_helpers. |
@jonhealy1 thanks for the reminder I've had a go at moving bits to sfeos_helpers let me know if I've moved anything to the wrong place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Nice work!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Nice work!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! This is a great addition
Description:
Adds PATCH endpoints to transaction extension. Adds support for RFC 6902 and RFC 7396. Pivots on header Content-Type value.
Related pull requests:
PR Checklist:
pre-commit run --all-files
)make test
)