Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ci: Workflow changes in preparation for release-candidates #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2024
Merged

ci: Workflow changes in preparation for release-candidates #470

merged 1 commit into from
Dec 5, 2024

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Dec 4, 2024 •
edited
Loading

See https://github.com/stackabletech/stackable-utils/pull/95/files

This PR:

  • extends the tag regex to allow optional -rcXX suffixes
  • suppresses the automatic setting of the version when merging a PR to a branch other than main. The version should be set in the PR creation (e.g. using stackable-utils): if this is not done then an error ocurs in the workflow e.g. Cannot downgrade from 24.11.1-rc1 to 0.0.0-pr550

@adwk67 adwk67 self-assigned this Dec 4, 2024
@adwk67 adwk67 requested a review from a team December 4, 2024 16:37
razvan
razvan approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adwk67 adwk67 added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 13ec44c Dec 5, 2024
2 checks passed
@adwk67 adwk67 deleted the ci/release-candidate-changes branch December 5, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvan razvan razvan approved these changes

Assignees

@adwk67 adwk67

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adwk67 @razvan