Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use the local supported version by default if no consensus is found #6341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 2, 2025
Merged

Use the local supported version by default if no consensus is found #6341

merged 5 commits into from
Aug 2, 2025

Conversation

@jferrant
Copy link
Contributor

@jferrant jferrant commented Jul 30, 2025

To mitigate the stall described in #6338

@jferrant jferrant requested review from a team as code owners July 30, 2025 18:19
@jferrant jferrant requested a review from obycode July 30, 2025 18:19
obycode
obycode previously approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think this makes sense until we're sure that we can reliably reach consensus.

@jferrant jferrant requested review from a team, hstove and kantai July 30, 2025 18:29
kantai
kantai reviewed Jul 30, 2025
View reviewed changes
@jferrant
Add a test to verify on startup that a signer reads both its own sign…
bcf5e62 
…erdb and the stackerdb for updates before proceeding

Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
CRC: do not default to the local supported version unless it does not…
66287db 
… support global consensus

Signed-off-by: Jacinta Ferrant <[email protected]>
jferrant
jferrant commented Jul 30, 2025
View reviewed changes
@jferrant jferrant requested review from kantai and obycode July 30, 2025 22:37
@jferrant jferrant added this pull request to the merge queue Aug 2, 2025
Merged via the queue into stacks-network:develop with commit 61e4f1c Aug 2, 2025
1 of 2 checks passed
@jferrant jferrant deleted the fix/use-local-protocol-version branch August 2, 2025 00:24
@codecov
Copy link

codecov bot commented Aug 2, 2025

Codecov Report

❌ Patch coverage is 2.17391% with 135 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.91%. Comparing base (799953e) to head (dd590f8).
⚠️ Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
stacks-node/src/tests/signer/v0.rs 0.00% 104 Missing ⚠️
stacks-node/src/tests/signer/mod.rs 0.00% 20 Missing ⚠️
stacks-signer/src/signerdb.rs 0.00% 6 Missing ⚠️
stacks-signer/src/v0/signer.rs 37.50% 5 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #6341      +/-   ##
===========================================
+ Coverage    81.00%   81.91%   +0.91%     
===========================================
  Files          541      541              
  Lines       347855   347991     +136     
===========================================
+ Hits        281772   285057    +3285     
+ Misses       66083    62934    -3149
Files with missing lines Coverage Δ
stacks-signer/src/v0/signer.rs 76.81% <37.50%> (-1.12%) ⬇️
stacks-signer/src/signerdb.rs 92.46% <0.00%> (-0.28%) ⬇️
stacks-node/src/tests/signer/mod.rs 80.11% <0.00%> (+4.33%) ⬆️
stacks-node/src/tests/signer/v0.rs 34.53% <0.00%> (-0.16%) ⬇️

... and 50 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799953e...dd590f8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Aug 10, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jcnelson jcnelson jcnelson approved these changes

@hstove hstove Awaiting requested review from hstove

+2 more reviewers

@kantai kantai kantai approved these changes

@obycode obycode obycode approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

locked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jferrant @jcnelson @kantai @obycode