[6.x] Apply correct icon classes to appended input icons #13051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp Daun <[email protected]>
Member
|
Default icons are the prepended icons. They're the same. It's default/prepend vs appended. |
Member
|
Sorry I may have misspoke. Gimme a chance for another look. |
Member
|
You can see the issue more clearly yourself by doing this on the master branch:
|
Member
|
Apologies for rushing the review earlier, this is a lovely, elegant solution to a problem I didn't realize we had. Thank you @daun! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been working on a custom listing UI and noticed that appended icons current don't work for the
Inputcomponent. They end up in the same position as the prepended icons, overlaid over each other. The solution is splitting out the prepended and appended icon classes as these shouldn't be applied to both icon slots equally.Example
<Input icon="search" placeholder="Search..." clearable="true" />Before
After
Note
Split icon class logic into separate prepended/appended variants and update template bindings to correctly position input icons.
packages/ui/src/Input/Input.vue)iconClassesand keep only shared styling.prependedIconClasses(start-0with size-based padding) andappendedIconClasses(end-0with size-based padding).prependedIconClassesfor the prepend slot andappendedIconClassesfor the append slot to position icons correctly.Written by Cursor Bugbot for commit d59924b. This will update automatically on new commits. Configure here.