[6.x] Add disabled state for Field Actions to improve UX of expand/collapse buttons in Bard/Replicator fieldtypes #13244
Conversation
|
Further to this too... as you can see by the commits, I originally just toggled buttons on and off - but this felt a bit weird with visual changes that felt a bit unnecessary. The If it was a case of showing "Expand" OR "Collapse", a toggle button makes a lot more sense. But given, depending on the replicator's config and the user's open/closed states, there is valid scenarios where both buttons are needed. Just my logic here. |
|
Updated for Bard too A new computed property The expand/collapse disabled state has been applied to these buttons too. |
|
Heck yeah this is a great improvement — kicking myself I didn't think to do it the first time. Thank you! |
|
I think if you have a simple setup you don't really notice it - but on bigger lists of Sets where suddenly it goes well past the viewport, it became a bit more head scratching. Love the new buttons compared to the dropdown menu though: makes so much more sense from a UX perspective. |
The new Quick Actions have the Expand All and Collapse All buttons shown all the time, and are active all the time
The issue is that if you click "Expand All", the button has no change to its state or behaviour - so you can keep clicking but nothing happens or changes.
This PR is addressing two things:
disabledprop or callback.The Expand button:
collapseis notaccordion)The Collapse button:
This allows the buttons to be more meaningfully shown and their state toggled based on their potential for an action.