-
-
Notifications
You must be signed in to change notification settings - Fork 596
[6.x] Theme selector #13293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.x] Theme selector #13293
Conversation
# Conflicts: # resources/js/bootstrap/statamic.js # resources/js/components/ColorMode.js # resources/views/partials/head.blade.php # src/Auth/User.php # src/Http/View/Composers/JavascriptComposer.php
When you edit custom values, the option to publish becomes available and takes you to statamic.com to publish in your account. The next time you switch to the themes tab, it'll refresh / bust the cache so you will see your newly added theme. Added some methods to the Marketplace client that'll handle busting the cache. Realized there's two layers of caching. Just going to work around that for now. Fixing is out of scope of this PR.
… share if its unchanged
|
cursor review |
…ences should still work.
…rride a parent theme preference
|
Hey Jason. I'm wondering what would be the best way to default a theme in a starter kit? I've also noticed somehow my theme is published but I don't recall doing this. I'm guessing you might've done this during testing? Which is fine of course. If I republish after making changes, does it overwrite the current published version? Happy days for you and yours. |
|
Never mind Jason, think I figured it out. However I'm wondering if themes will update on the client site when a theme is re-published. |
This PR adds a theme selector UI.
The theme is now part of preferences, and can be applied to the user/role/defaults like all other preferences.
You can publish your custom themes to the marketplace and they will be available to browse and select from within the control panel.
Breaking change
(But not really breaking since themes were introduced in an Alpha.)
The config-based way of defining your theme has been removed. If you need to migrate it, you can drop this Artisan command into
routes/console.phpand runphp artisan theme:migrate