Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

zbianca
Copy link
Contributor

@zbianca zbianca commented Jun 29, 2025

fixes #6322

What is the current behavior?

Toggle event handlers have type Event.

GitHub Issue Number: 6322

What is the new behavior?

Toggle event handlers have type ToggleEvent.

Documentation

Does this introduce a breaking change?

  • Yes
  • No

@zbianca zbianca requested a review from a team as a code owner June 29, 2025 16:17
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘

@zbianca zbianca force-pushed the fix/add-toggle-event-type branch from 1c64e0e to 77660a6 Compare June 29, 2025 16:58
@zbianca zbianca force-pushed the fix/add-toggle-event-type branch from 77660a6 to 82a69d3 Compare June 29, 2025 16:59
@christian-bromann christian-bromann merged commit 5925974 into stenciljs:main Jun 30, 2025
70 checks passed
@christian-bromann
Copy link
Member

Thank you @zbianca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: "beforetoggle" and "toggle" events should have type ToggleEvent
2 participants