[WIP] Data uploader tool for Netbox #30
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidFair
requested changes
Mar 24, 2023
|
|
||
| self._netbox_api = NetboxApi.api_object(url, token, cert) | ||
|
|
||
| def get_device(self, hostname: str): |
There was a problem hiding this comment.
Can we add return types too:
def get_device(self, hostname: str) -> Union[Dict[Record], None]:
(That is assuming there's a Record class or similar in Python. If not you can just use Union[Dict, None] to show it will either return a dict or None
Comment on lines
26
to
28
| #error with line below | ||
| #test we do get a value returned | ||
| #assert response == NetboxDcim.get_device(hostname=mock_device_name).return_value |
There was a problem hiding this comment.
We should either remove this or have a go at fixing it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress
This PR would set up a package with tools for bulk uploads of new data to Netbox.
It would include checks for whether there is matching data already in Netbox (e.g. IP Address, MAC address, hostname etc) before creating a new dcim or ipam object in Netbox