client: Fix bool operator on init and ongoing use#17
Merged
Conversation
9c33670 to
d899527
Compare
rzr
added a commit
to TizenTeam/STM32Ethernet
that referenced
this pull request
Jan 4, 2019
When iterating we make sure client's socket is not closing since _tcp_client remains after close. This was tested on nuleo-f767zi using project webthing-arduino Change-Id: Ie465fe59009c33957dad97f1c70b4dc3af3b2ebe Forwarded: stm32duino#17 Signed-off-by: Philippe Coval <[email protected]>
When iterating we make sure client's socket is not closing since _tcp_client remains after close. This was tested on nuleo-f767zi using project webthing-arduino Change-Id: Ie465fe59009c33957dad97f1c70b4dc3af3b2ebe Forwarded: stm32duino#17 Signed-off-by: Philippe Coval <[email protected]>
d899527 to
507d586
Compare
rzr
added a commit
to TizenTeam/STM32Ethernet
that referenced
this pull request
Jan 4, 2019
I noticed that server worked on global instance. but not if used in class (allocated with new). This change makes both use working. Forwarded: stm32duino#17 Relate-to: https://github.com/rzr/webthing-iotjs/wiki/MCU Change-Id: I2e21e34a43f3cadb7981f2e359a5960735daa5d3 Signed-off-by: Philippe Coval <[email protected]>
fpistm
reviewed
Jan 4, 2019
Member
fpistm
left a comment
There was a problem hiding this comment.
Thanks for this PR.
Only one comment to discuss
Also replace default constructor to use port 80 by default. I noticed that server worked on global instance. but not if used in class (allocated with new). This change makes both use cases working. Forwarded: stm32duino#17 Relate-to: https://github.com/rzr/webthing-iotjs/wiki/MCU Change-Id: I2e21e34a43f3cadb7981f2e359a5960735daa5d3 Signed-off-by: Philippe Coval <[email protected]>
507d586 to
a443221
Compare
fpistm
approved these changes
Jan 4, 2019
Contributor
Author
|
For the record this change is released in: |
Member
|
@rzr |
Contributor
Author
|
OK, Sorry for noise May relate to: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When iterating we make sure client's socket is not closing
since _tcp_client remains after close.
This was tested on nuleo-f767zi using project webthing-arduino
Change-Id: Ie465fe59009c33957dad97f1c70b4dc3af3b2ebe
Signed-off-by: Philippe Coval [email protected]