feat: change file for exists share#306
Conversation
|
Thanks! I'll look into it at the weekend. |
stonith404
left a comment
There was a problem hiding this comment.
Sorry for being so picky, but these should be only small changes. I really like the implementation of the feature. Thank you! :)
|
Thank you for your suggestions. The points you mentioned are also areas where I am hesitant. I will revise them before submitting. In addition, I would like to know, from your perspective, after the user modifies the Share and clicks the save button, do you directly prompt the user with a toast or pop up the current modal box? And should I stay on the current page instead of jumping to the home page? |
|
@IvanLi-CN, for me, it doesn't really matter. Do what you think is best. If you ask for my opinion, I would suggest redirecting back to the "My Shares" page, as that is the page the user is coming from. |
fd04aff to
a7c4a09
Compare
|
Modified, please check 😋 @stonith404 |
stonith404
left a comment
There was a problem hiding this comment.
Great, thank you! Can I merge?
Do it! 😋 |
|
Wow nice changes, good job ! |
close #154 .
This is the effect achieved. Is there anything that needs to be adjusted in the process?
output_hevc.mp4