This repository was archived by the owner on May 18, 2026. It is now read-only.
feat(oauth): limited discord server sign-in#346
Merged
stonith404 merged 4 commits intoNov 30, 2023
Conversation
stonith404
reviewed
Nov 26, 2023
stonith404
approved these changes
Nov 26, 2023
Owner
stonith404
left a comment
There was a problem hiding this comment.
The code looks good to me. I can't really test it as I don't have an own Discord server but if you've tested it properly we can merge it.
Contributor
Author
|
@stonith404 Can you build a dev image please? I will test it on my server tomorrow. |
Owner
|
@zz5840 Done 👍 |
Contributor
Author
|
@stonith404 I've tested it on my server, and it works as expected. Hope we can merge it. |
Owner
|
Sorry for the late response. Should I wait for your second PR before creating a new release? |
Contributor
Author
|
@stonith404 Either is fine, but it will take an extra week or two to complete that PR. If you want people to try this feature ASAP, it's better to create a new release. |
Owner
|
@zz5840 Great, I've created the release. Thank you for the contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #338