This repository was archived by the owner on May 18, 2026. It is now read-only.
feat(oauth): add oidc username claim#357
Merged
Merged
Conversation
Owner
|
Thanks :) I'm currently not at home but I'll review it at the start of the next week. |
stonith404
reviewed
Dec 19, 2023
Contributor
Author
|
@stonith404 Anything else I should update? |
stonith404
approved these changes
Dec 19, 2023
Owner
stonith404
left a comment
There was a problem hiding this comment.
Sorry, I was interrupted while reviewing. Yes this looks fine, thanks!
Owner
|
@zz5840 Can we merge? |
Contributor
Author
|
@stonith404 Yeah, please merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #355