Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 18, 2026. It is now read-only.

feat(frontend): add navigateToLink button for CopyTextField. close #372.#376

Merged
stonith404 merged 2 commits into
stonith404:mainfrom
IvanLi-CN:feat/add-navigate-to-link-btn-for-link-field
Jan 9, 2024
Merged

feat(frontend): add navigateToLink button for CopyTextField. close #372.#376
stonith404 merged 2 commits into
stonith404:mainfrom
IvanLi-CN:feat/add-navigate-to-link-btn-for-link-field

Conversation

@IvanLi-CN
Copy link
Copy Markdown
Contributor

At present, I see 3 places to use this link field component. I feel quite suitable for adding this function. The Navigate to Link button is optional and enabled by default.

image image

@IvanLi-CN IvanLi-CN marked this pull request as ready for review January 8, 2024 13:18
@stonith404
Copy link
Copy Markdown
Owner

Great, thank you! That's a nice addition.

Two things:

  1. Is the openBtn parameter really necessary as the the parameter is never used?
  2. I think it would make more sense if the link gets opened in a new window. Or do you disagree?

@IvanLi-CN
Copy link
Copy Markdown
Contributor Author

  1. openBtn is currently not used, and I'm hesitant to remove it. I'd better delete this parameter.
  2. When I use this feature I mainly open it from the new tab page as well. However, I think it should be up to the user to decide if they want to open it in a new tab or not, I currently open the page in the background via the middle mouse button and then switch tabs over. It's a bit of a hassle, but so many sites do it. Maybe I'm overthinking it.

@stonith404
Copy link
Copy Markdown
Owner

Great! Thanks for your contribution :)

@stonith404 stonith404 merged commit d775008 into stonith404:main Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants