feat: add more options to reverse shares#495
Conversation
f819bfa to
c129698
Compare
I have added a prompt message which will be displayed if an email has been sent to the creator of the Reverse Share by the backend. |
|
I have added an option in the interface for creating reverse shares. This option is used to indicate whether the shares associated with this reverse share can be accessed by others. By default, it is set to public access. 
No permission alert: 
The creator of the reverse share and the creator of the share have free access. This option reduces the risk of the service being abused and subject to security risks. |
|
Thanks @IvanLi-CN, I'll look into it ASAP. |
stonith404
left a comment
There was a problem hiding this comment.
Thank you very much for your contribution. I really like the new options :)
I added a few comments, feel free to comment if something is unclear or you don't agree.
593d151 to
59c8d80
Compare
|
Thank you very much for your advice. I have left some comments and would like to hear your thoughts. |
c9d6814 to
473901d
Compare
…the reverse share creator.
Co-authored-by: Elias Schneider <[email protected]> Update frontend/src/i18n/translations/en-US.ts Co-authored-by: Elias Schneider <[email protected]> Update frontend/src/i18n/translations/en-US.ts Co-authored-by: Elias Schneider <[email protected]> chore(i18n): Improve translation.
473901d to
8333d4f
Compare
|
The PR has been updated. I've addressed all the feedback and it should be good to go now. |
|
Great, thanks again for your contribution :) |
output_hevc.mp4
The above is the effect currently achieved.
I have encountered some issues:
When creating a reverse share, if the recipient has already enabled email notifications, I would like to add a message in the "Share ready" dialog box to inform the uploader: "The system has notified the recipient to check the file. You can also copy the share link above to inform them."
This is my personal suggestion, and I would like to know if you think this prompt should be added. If you agree with this small prompt, perhaps we can expose the ReverseShare.sendEmailNotification field to determine the specific prompt text.
I believe that files shared via reverse sharing should only be visible to the creator of the reverse share. Additionally, since I have removed the password option in the simplified interface, should we restrict the visibility of shares created through reverse sharing to only ReverseShare.creator and Share.creator?
@stonith404