fix(oauth): Provider username is ignored when signing up using OAuth#511
Conversation
Fixes #505 Signed-off-by: Marvin A. Ruder <[email protected]>
|
Should we also change the priority order of provider usernames? pingvin-share/backend/src/oauth/provider/genericOidc.provider.ts Lines 126 to 130 in 6d6b9e8 If we receive a |
|
Thank you very much for your PR, and I apologize for the delayed response. I think this change makes absolutely sense but there’s a potential issue with username conflicts since Pingvin Share supports multiple authentication methods. I would suggest attempting the sign-up with the provider’s username, and if it fails due to a conflict, we can then use the getAvailableUsername method to generate a unique username and proceed with the sign-up process. What do you think? And yes, prioritizing |
* Reprioritize claims for OIDC provider username Signed-off-by: Marvin A. Ruder <[email protected]>
Fixes #505