Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 18, 2026. It is now read-only.

feat(s3): allow disabling upload checksum#804

Merged
stonith404 merged 2 commits into
stonith404:mainfrom
marekhanzlik:s3_checksum_disable
Apr 4, 2025
Merged

feat(s3): allow disabling upload checksum#804
stonith404 merged 2 commits into
stonith404:mainfrom
marekhanzlik:s3_checksum_disable

Conversation

@marekhanzlik
Copy link
Copy Markdown
Contributor

@marekhanzlik marekhanzlik commented Mar 28, 2025

Adds a S3 config option to disable upload checksums. Allows use of Backblaze B2 backend which does not support x-amz-checksum-* headers (rejects it as hard error).

Relates to #798, #788

Tested it against Backblaze B2 and its working.

@marekhanzlik marekhanzlik changed the title [#798] S3 - toggle useChecksum feat(s3): allow disabling upload checksum Mar 28, 2025
@marekhanzlik
Copy link
Copy Markdown
Contributor Author

@stonith404 Can you please check it? Thanks.

Comment thread frontend/src/i18n/translations/en-US.ts Outdated
Copy link
Copy Markdown
Owner

@stonith404 stonith404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@stonith404 stonith404 merged commit 73a76a9 into stonith404:main Apr 4, 2025
@truthsword
Copy link
Copy Markdown

How is this done through the configuration file config.yaml (not shown in the example file). Thank you.

Configuration file present
As you have a configured Pingvin Share with a configuration file, you can't change the configuration through the UI.

@stonith404
Copy link
Copy Markdown
Owner

The config.example.yaml should now be up to date.

@truthsword
Copy link
Copy Markdown

OK Thanks!. But now nothing happens when I click share? Just a spinning thing. No change in logs... no progress bar, and I'm warned that the upload will abort if I close the browser tab. Guess this isn't for me. Thanks anyway... this is an impressive work, but I need Backblaze B2 as a file repo.

@marekhanzlik
Copy link
Copy Markdown
Contributor Author

@truthsword so you set it to "false"?

@truthsword
Copy link
Copy Markdown

Yes, the error I had went away. The last log item didn't change from container startup. Something about ClamAV... The s3 URL required me to add https:// as it wouldn't accept just a subdomain. B2 doesn't use region names. so initially I left it blank, but got an error, so I entered the regional subdomain. Initially I left the storage directory blank, but when nothing happened, I randomly entered "pingvin" and still nothing.

@marekhanzlik
Copy link
Copy Markdown
Contributor Author

@truthsword Tried it with config and works as expected

My configuration:

s3:
  enabled: "true"
  endpoint: "https://s3.eu-central-003.backblazeb2.com"
  region: "eu-central-003"
  bucketName: "upload_bucket"
  bucketPath: "upload_folder"
  key: "< api key id >"
  secret: "< api key >"
  useChecksum: "false"

@truthsword
Copy link
Copy Markdown

Thanks, but nothing happens. I am connecting by local IP.

http://192.168.1.42:3000

I must be missing something basic.
Here are my S3 settings:

s3:
  #Whether S3 should be used to store the shared files instead of the local file system.
  enabled: "true"
  #The URL of the S3 bucket.
  endpoint: "https://s3.us-west-002.backblazeb2.com"
  #The region of the S3 bucket.
  region: "us-west-002"
  #The name of the S3 bucket.
  bucketName: "my-bucket"
  #The default path which should be used to store the files in the S3 bucket.
  bucketPath: "pingvin"
  #The key which allows you to access the S3 bucket.
  key: "002xxx"
  #The secret which allows you to access the S3 bucket.
  secret: "K002xxx"
  #Turn off for backends that do not support checksum (e.g. B2).
  useChecksum: "false"

And my compose file:

services:
  pingvin:
    image: stonith404/pingvin-share # or ghcr.io/stonith404/pingvin-share
    container_name: pingvin
    restart: unless-stopped
    ports:
      - 3000:3000
    environment:
      - PUID=1000
      - PGID=1000
      - TRUST_PROXY=false # Set to true if a reverse proxy is in front of the container
    volumes:
      - ./data:/opt/app/backend/data
      - ./images:/opt/app/frontend/public/img
      - ./config.yaml:/opt/app/config.yaml # Add this line, if you want to configure pingvin-share vi>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants