From bdfa4c1e22f57fdddea6aa792d693d66ce9a377b Mon Sep 17 00:00:00 2001 From: Simon Ho Date: Tue, 25 Oct 2016 14:52:31 -0700 Subject: [PATCH 1/4] Update test confirmation text in PR template We only ask users to check when adding new tests, but some PRs only modify existing tests. Also added instructions to mark with an "x" for checking off items. --- .github/PULL_REQUEST_TEMPLATE.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 58c8d7b2d..4d3ab2e6f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -14,6 +14,10 @@ Please use the following link syntaxes: ### Checklist -- [ ] New tests are added to cover all changes + + +- [ ] New tests add or existing tests modified to cover all changes - [ ] Code conforms with the [style guide](http://loopback.io/doc/en/contrib/style-guide.html) From 8881fc4f15906fe974d551e3d6da4c1c3ebaa9d7 Mon Sep 17 00:00:00 2001 From: Simon Ho Date: Tue, 25 Oct 2016 14:53:24 -0700 Subject: [PATCH 2/4] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 4d3ab2e6f..a589676fd 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -18,6 +18,6 @@ Please use the following link syntaxes: Please mark your choice with an "x" (eg. [x], not [*]) --> -- [ ] New tests add or existing tests modified to cover all changes +- [ ] New tests added or existing tests modified to cover all changes - [ ] Code conforms with the [style guide](http://loopback.io/doc/en/contrib/style-guide.html) From d58c7c55b6c91f869edb217ba556df4544d7747b Mon Sep 17 00:00:00 2001 From: Simon Ho Date: Thu, 27 Oct 2016 23:55:47 -0700 Subject: [PATCH 3/4] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a589676fd..b95277398 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -15,7 +15,9 @@ Please use the following link syntaxes: ### Checklist - [ ] New tests added or existing tests modified to cover all changes From cd6f2d5028d24c7b532d0b472a4d092cead9df11 Mon Sep 17 00:00:00 2001 From: Simon Ho Date: Thu, 27 Oct 2016 23:57:54 -0700 Subject: [PATCH 4/4] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b95277398..d2b240f57 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -16,8 +16,7 @@ Please use the following link syntaxes: - [ ] New tests added or existing tests modified to cover all changes