Globalize using strong-globalize #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 tasks
lib/rest-builder.js
Outdated
| RequestBuilder.prototype._request = function(uri, options, cb) { | ||
| if (typeof uri === 'undefined') { | ||
| throw new Error('undefined is not a valid uri or options object.'); | ||
| throw new Error(g.f('undefined is not a valid uri or options object.')); |
Contributor
There was a problem hiding this comment.
{{undefined}} {{uri}} {{options}} and possibly {{object}}
Contributor
|
One line needs resolution, other comment is a nitpick. Otherwise LGTM. |
Contributor
Author
|
@slnode test please |
Contributor
|
LGTM |
Contributor
Author
|
@slnode test please |
lib/rest-connector.js
Outdated
| } | ||
| } else { | ||
| callback && callback('Error response: ' + response.statusCode, body); | ||
| var err = g.f('Error response: %s %j', response.statusCode, body); |
Contributor
There was a problem hiding this comment.
%d for statusCode which is a number I assume?
Contributor
|
Two minor comments, otherwise LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect to strongloop/loopback/issues/2422