top cache

xuxinhua · xuxinhua · commit f27a9a428549 · 2023-09-23T13:34:19.000+08:00
diff --git a/internal/dao/cache/feed.go b/internal/dao/cache/feed.go
@@ -22,6 +22,10 @@ func (feedCache) GetTop(ctx context.Context) []*model.Feed {
 		return nil
 	}
 
+	if s == "notop" {
+		return []*model.Feed{}
+	}
+
 	feeds := make([]*model.Feed, 0)
 	err := json.Unmarshal([]byte(s), &feeds)
 	if err != nil {
@@ -35,8 +39,13 @@ func (feedCache) SetTop(ctx context.Context, feeds []*model.Feed) {
 	redisClient := nosql.NewRedisClient()
 	defer redisClient.Close()
 
-	b, _ := json.Marshal(feeds)
-	redisClient.SET("feed:top", string(b), 300)
+	val := "notop"
+	if len(feeds) > 0 {
+		b, _ := json.Marshal(feeds)
+		val = string(b)
+	}
+
+	redisClient.SET("feed:top", val, 300)
 }
 
 func (feedCache) GetList(ctx context.Context, p int) []*model.Feed {
diff --git a/internal/logic/feed.go b/internal/logic/feed.go
@@ -80,7 +80,7 @@ func (self FeedLogic) FindTop(ctx context.Context) []*model.Feed {
 	objLog := GetLogger(ctx)
 
 	feeds := cache.Feed.GetTop(ctx)
-	if len(feeds) > 0 {
+	if feeds != nil {
 		return feeds
 	}
 
@@ -92,9 +92,7 @@ func (self FeedLogic) FindTop(ctx context.Context) []*model.Feed {
 	}
 
 	feeds = self.fillOtherInfo(ctx, feeds, false)
-	if len(feeds) > 0 {
-		cache.Feed.SetTop(ctx, feeds)
-	}
+	cache.Feed.SetTop(ctx, feeds)
 	return feeds
 }
 

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ func (self FeedLogic) FindTop(ctx context.Context) []*model.Feed {`
`80`	`80`	`objLog := GetLogger(ctx)`
`81`	`81`
`82`	`82`	`feeds := cache.Feed.GetTop(ctx)`
`83`		`- if len(feeds) > 0 {`
	`83`	`+ if feeds != nil {`
`84`	`84`	`return feeds`
`85`	`85`	`}`
`86`	`86`
`@@ -92,9 +92,7 @@ func (self FeedLogic) FindTop(ctx context.Context) []*model.Feed {`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`feeds = self.fillOtherInfo(ctx, feeds, false)`
`95`		`- if len(feeds) > 0 {`
`96`		`- cache.Feed.SetTop(ctx, feeds)`
`97`		`- }`
	`95`	`+ cache.Feed.SetTop(ctx, feeds)`
`98`	`96`	`return feeds`
`99`	`97`	`}`
`100`	`98`