Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit ed05460

Browse files
authored
semantic-conventions: don't annotate Enum values with Final (open-telemetry#4085)
1 parent ed8d950 commit ed05460

32 files changed

+399
-396
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## Unreleased
99

10+
- Drop Final annotation from Enum in semantic conventions
11+
([#4085](https://github.com/open-telemetry/opentelemetry-python/pull/4085))
12+
1013
## Version 1.26.0/0.47b0 (2024-07-25)
1114

1215
- Standardizing timeout calculation in measurement consumer collect to nanoseconds

opentelemetry-semantic-conventions/src/opentelemetry/semconv/_incubating/attributes/aws_attributes.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@
287287

288288

289289
class AwsEcsLaunchtypeValues(Enum):
290-
EC2: Final = "ec2"
290+
EC2 = "ec2"
291291
"""ec2."""
292-
FARGATE: Final = "fargate"
292+
FARGATE = "fargate"
293293
"""fargate."""

opentelemetry-semantic-conventions/src/opentelemetry/semconv/_incubating/attributes/cloud_attributes.py

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -67,76 +67,76 @@
6767

6868

6969
class CloudPlatformValues(Enum):
70-
ALIBABA_CLOUD_ECS: Final = "alibaba_cloud_ecs"
70+
ALIBABA_CLOUD_ECS = "alibaba_cloud_ecs"
7171
"""Alibaba Cloud Elastic Compute Service."""
72-
ALIBABA_CLOUD_FC: Final = "alibaba_cloud_fc"
72+
ALIBABA_CLOUD_FC = "alibaba_cloud_fc"
7373
"""Alibaba Cloud Function Compute."""
74-
ALIBABA_CLOUD_OPENSHIFT: Final = "alibaba_cloud_openshift"
74+
ALIBABA_CLOUD_OPENSHIFT = "alibaba_cloud_openshift"
7575
"""Red Hat OpenShift on Alibaba Cloud."""
76-
AWS_EC2: Final = "aws_ec2"
76+
AWS_EC2 = "aws_ec2"
7777
"""AWS Elastic Compute Cloud."""
78-
AWS_ECS: Final = "aws_ecs"
78+
AWS_ECS = "aws_ecs"
7979
"""AWS Elastic Container Service."""
80-
AWS_EKS: Final = "aws_eks"
80+
AWS_EKS = "aws_eks"
8181
"""AWS Elastic Kubernetes Service."""
82-
AWS_LAMBDA: Final = "aws_lambda"
82+
AWS_LAMBDA = "aws_lambda"
8383
"""AWS Lambda."""
84-
AWS_ELASTIC_BEANSTALK: Final = "aws_elastic_beanstalk"
84+
AWS_ELASTIC_BEANSTALK = "aws_elastic_beanstalk"
8585
"""AWS Elastic Beanstalk."""
86-
AWS_APP_RUNNER: Final = "aws_app_runner"
86+
AWS_APP_RUNNER = "aws_app_runner"
8787
"""AWS App Runner."""
88-
AWS_OPENSHIFT: Final = "aws_openshift"
88+
AWS_OPENSHIFT = "aws_openshift"
8989
"""Red Hat OpenShift on AWS (ROSA)."""
90-
AZURE_VM: Final = "azure_vm"
90+
AZURE_VM = "azure_vm"
9191
"""Azure Virtual Machines."""
92-
AZURE_CONTAINER_APPS: Final = "azure_container_apps"
92+
AZURE_CONTAINER_APPS = "azure_container_apps"
9393
"""Azure Container Apps."""
94-
AZURE_CONTAINER_INSTANCES: Final = "azure_container_instances"
94+
AZURE_CONTAINER_INSTANCES = "azure_container_instances"
9595
"""Azure Container Instances."""
96-
AZURE_AKS: Final = "azure_aks"
96+
AZURE_AKS = "azure_aks"
9797
"""Azure Kubernetes Service."""
98-
AZURE_FUNCTIONS: Final = "azure_functions"
98+
AZURE_FUNCTIONS = "azure_functions"
9999
"""Azure Functions."""
100-
AZURE_APP_SERVICE: Final = "azure_app_service"
100+
AZURE_APP_SERVICE = "azure_app_service"
101101
"""Azure App Service."""
102-
AZURE_OPENSHIFT: Final = "azure_openshift"
102+
AZURE_OPENSHIFT = "azure_openshift"
103103
"""Azure Red Hat OpenShift."""
104-
GCP_BARE_METAL_SOLUTION: Final = "gcp_bare_metal_solution"
104+
GCP_BARE_METAL_SOLUTION = "gcp_bare_metal_solution"
105105
"""Google Bare Metal Solution (BMS)."""
106-
GCP_COMPUTE_ENGINE: Final = "gcp_compute_engine"
106+
GCP_COMPUTE_ENGINE = "gcp_compute_engine"
107107
"""Google Cloud Compute Engine (GCE)."""
108-
GCP_CLOUD_RUN: Final = "gcp_cloud_run"
108+
GCP_CLOUD_RUN = "gcp_cloud_run"
109109
"""Google Cloud Run."""
110-
GCP_KUBERNETES_ENGINE: Final = "gcp_kubernetes_engine"
110+
GCP_KUBERNETES_ENGINE = "gcp_kubernetes_engine"
111111
"""Google Cloud Kubernetes Engine (GKE)."""
112-
GCP_CLOUD_FUNCTIONS: Final = "gcp_cloud_functions"
112+
GCP_CLOUD_FUNCTIONS = "gcp_cloud_functions"
113113
"""Google Cloud Functions (GCF)."""
114-
GCP_APP_ENGINE: Final = "gcp_app_engine"
114+
GCP_APP_ENGINE = "gcp_app_engine"
115115
"""Google Cloud App Engine (GAE)."""
116-
GCP_OPENSHIFT: Final = "gcp_openshift"
116+
GCP_OPENSHIFT = "gcp_openshift"
117117
"""Red Hat OpenShift on Google Cloud."""
118-
IBM_CLOUD_OPENSHIFT: Final = "ibm_cloud_openshift"
118+
IBM_CLOUD_OPENSHIFT = "ibm_cloud_openshift"
119119
"""Red Hat OpenShift on IBM Cloud."""
120-
TENCENT_CLOUD_CVM: Final = "tencent_cloud_cvm"
120+
TENCENT_CLOUD_CVM = "tencent_cloud_cvm"
121121
"""Tencent Cloud Cloud Virtual Machine (CVM)."""
122-
TENCENT_CLOUD_EKS: Final = "tencent_cloud_eks"
122+
TENCENT_CLOUD_EKS = "tencent_cloud_eks"
123123
"""Tencent Cloud Elastic Kubernetes Service (EKS)."""
124-
TENCENT_CLOUD_SCF: Final = "tencent_cloud_scf"
124+
TENCENT_CLOUD_SCF = "tencent_cloud_scf"
125125
"""Tencent Cloud Serverless Cloud Function (SCF)."""
126126

127127

128128
class CloudProviderValues(Enum):
129-
ALIBABA_CLOUD: Final = "alibaba_cloud"
129+
ALIBABA_CLOUD = "alibaba_cloud"
130130
"""Alibaba Cloud."""
131-
AWS: Final = "aws"
131+
AWS = "aws"
132132
"""Amazon Web Services."""
133-
AZURE: Final = "azure"
133+
AZURE = "azure"
134134
"""Microsoft Azure."""
135-
GCP: Final = "gcp"
135+
GCP = "gcp"
136136
"""Google Cloud Platform."""
137-
HEROKU: Final = "heroku"
137+
HEROKU = "heroku"
138138
"""Heroku Platform as a Service."""
139-
IBM_CLOUD: Final = "ibm_cloud"
139+
IBM_CLOUD = "ibm_cloud"
140140
"""IBM Cloud."""
141-
TENCENT_CLOUD: Final = "tencent_cloud"
141+
TENCENT_CLOUD = "tencent_cloud"
142142
"""Tencent Cloud."""

opentelemetry-semantic-conventions/src/opentelemetry/semconv/_incubating/attributes/container_attributes.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,9 @@
8787

8888

8989
class ContainerCpuStateValues(Enum):
90-
USER: Final = "user"
90+
USER = "user"
9191
"""When tasks of the cgroup are in user mode (Linux). When all container processes are in user mode (Windows)."""
92-
SYSTEM: Final = "system"
92+
SYSTEM = "system"
9393
"""When CPU is used by the system (host OS)."""
94-
KERNEL: Final = "kernel"
94+
KERNEL = "kernel"
9595
"""When tasks of the cgroup are in kernel mode (Linux). When all container processes are in kernel mode (Windows)."""

0 commit comments

Comments
 (0)