Add 1D models of the solar chromosphere to SunPy#8068
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Nabil Freij <[email protected]>
Co-authored-by: Nabil Freij <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Nabil Freij <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
|
This PR was discussed at length at the latest dev meeting, and @wtbarnes needs to write his thoughts here |
|
As mentioned above, there was some discussion of this PR at the community call approximately two weeks ago. I'll try my best to summarize here:
|
There was a problem hiding this comment.
This is better suited as an example gallery entry. There is only one way to accomplish this task and it has a visual component.
|
Thank you again for this PR @parharti and I apologize that this PR has gone so long without a follow-up review. We had some discussion today at the community meeting about this and we decided that we would like this to go into the core package, but that it probably makes sense to store these files elsewhere, most likely Zenodo, and then manage them using the remote data manager: https://docs.sunpy.org/en/stable/how_to/remote_data_manager.html#use-the-remote-data-manager. The idea would be to upload the latest table initially (probably the 2008 paper shown here as I believe it is the most recent and up to date model) and then upload later ones as needed. The hashes and URLs would be tracked here and downloaded as needed by the data manager. This would alleviated the need to keep these files in the repository. Furthermore, if we feel that the number of models, either these atmospheres or some other atmospheric profile, is continually growing, these could be spun out into their own package. @parharti As it has been a while, if you'd like, I could take over this PR and finish it up. |
|
I'm going to mark this as draft until someone picks it up. |
|
Hello 👋, Thanks for your contribution to sunpy! |
hey!!
In this PR I am solving the issue which requested addition of the new feature that is adding 1D model of chromosphere in sunpy
to solve this issue
Note-We can add more models if this approach works well.