Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add 1D models of the solar chromosphere to SunPy#8068

Draft
parharti wants to merge 78 commits into
sunpy:mainfrom
parharti:Prisha
Draft

Add 1D models of the solar chromosphere to SunPy#8068
parharti wants to merge 78 commits into
sunpy:mainfrom
parharti:Prisha

Conversation

@parharti
Copy link
Copy Markdown
Contributor

@parharti parharti commented Feb 8, 2025

hey!!
In this PR I am solving the issue which requested addition of the new feature that is adding 1D model of chromosphere in sunpy
to solve this issue

  • scratched table from the paper(https://iopscience.iop.org/article/10.1086/523671/pdf)) Table -26
  • Implemented a function to add 1D model:
  • By default, it generates a standard plot (tempertaure v/s height).
  • If arguments are passed, it allows for a custom plot.
  • Added a log parameter to provide a logarithmic curve when enabled

Note-We can add more models if this approach works well.

@parharti parharti requested a review from a team as a code owner February 8, 2025 15:16
@parharti parharti changed the title Prisha Add 1D models of the solar chromosphere to SunPy Feb 8, 2025
Comment thread sunpy/sun/models.py Outdated
@nabobalis

This comment was marked as outdated.

@nabobalis nabobalis marked this pull request as draft February 8, 2025 17:37
@nabobalis nabobalis added the sun Affects the sun submodule label Feb 8, 2025
Comment thread sunpy/sun/models.py Outdated
Comment thread sunpy/sun/models.py Outdated
Comment thread sunpy/sun/models.py Outdated
Comment thread sunpy/sun/models.py Outdated
@parharti

This comment was marked as outdated.

@parharti

This comment was marked as outdated.

@parharti parharti requested a review from ayshih February 10, 2025 20:32
Comment thread sunpy/sun/models.py Outdated
Comment thread sunpy/sun/models.py Outdated
Comment thread sunpy/sun/models.py Outdated
@nabobalis nabobalis removed request for a team and ayshih February 11, 2025 07:13
@parharti parharti requested a review from nabobalis February 11, 2025 08:02
@nabobalis nabobalis removed their request for review February 11, 2025 17:40
Comment thread sunpy/sun/models.py Outdated
Comment thread sunpy/sun/models.py Outdated
Comment thread sunpy/sun/models.py
Comment thread sunpy/sun/models.py Outdated
@nabobalis nabobalis removed the request for review from ayshih February 23, 2025 18:34
@nabobalis

This comment was marked as outdated.

@parharti parharti requested a review from a team as a code owner February 23, 2025 19:49
Comment thread docs/dev_guide/contents/adding_chromosphere_models.rst Outdated
@nabobalis

This comment was marked as outdated.

Comment thread docs/dev_guide/contents/adding_chromosphere_models.rst Outdated
@nabobalis nabobalis requested a review from ayshih February 24, 2025 17:28
@ayshih
Copy link
Copy Markdown
Member

ayshih commented Mar 1, 2025

This PR was discussed at length at the latest dev meeting, and @wtbarnes needs to write his thoughts here

@wtbarnes
Copy link
Copy Markdown
Member

wtbarnes commented Mar 11, 2025

As mentioned above, there was some discussion of this PR at the community call approximately two weeks ago. I'll try my best to summarize here:

Comment thread docs/how_to/plot_solar_atmos_model.rst Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better suited as an example gallery entry. There is only one way to accomplish this task and it has a visual component.

@parharti parharti requested a review from a team as a code owner April 29, 2025 11:43
@wtbarnes
Copy link
Copy Markdown
Member

wtbarnes commented Oct 1, 2025

Thank you again for this PR @parharti and I apologize that this PR has gone so long without a follow-up review.

We had some discussion today at the community meeting about this and we decided that we would like this to go into the core package, but that it probably makes sense to store these files elsewhere, most likely Zenodo, and then manage them using the remote data manager: https://docs.sunpy.org/en/stable/how_to/remote_data_manager.html#use-the-remote-data-manager. The idea would be to upload the latest table initially (probably the 2008 paper shown here as I believe it is the most recent and up to date model) and then upload later ones as needed. The hashes and URLs would be tracked here and downloaded as needed by the data manager.

This would alleviated the need to keep these files in the repository. Furthermore, if we feel that the number of models, either these atmospheres or some other atmospheric profile, is continually growing, these could be spun out into their own package.

@parharti As it has been a while, if you'd like, I could take over this PR and finish it up.

@Cadair
Copy link
Copy Markdown
Member

Cadair commented Oct 29, 2025

I'm going to mark this as draft until someone picks it up.

@Cadair Cadair marked this pull request as draft October 29, 2025 13:09
@Cadair Cadair removed the Needs Review Needs review(s) before merge. label Oct 29, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Hello 👋, Thanks for your contribution to sunpy!
I have marked this pull request as stale because there hasn't had any activity in five months. If you are still working on this, or if it's waiting on a maintainer to look at it then please let us know and we will keep it open. Please add a comment with: @sunpy/sunpy-developers to get someone's attention.
If nobody comments on this pull request for another month, it will be closed.

@github-actions github-actions Bot added the Stale The bot will close this PR after 6 months (if enabled on this repo). label Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) Stale The bot will close this PR after 6 months (if enabled on this repo). sun Affects the sun submodule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants