fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open-checkpatch-fixes

akpm00 · broonie · commit 28bd3b7a6d5b · 2014-09-01T23:49:06.000+01:00
WARNING: Missing a blank line after declarations torvalds#77: FILE: fs/proc/task_mmu.c:246: + int err = PTR_ERR(priv->mm); + seq_release_private(inode, file); total: 0 errors, 1 warnings, 94 lines checked ./patches/fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
@@ -225,6 +225,7 @@ static int proc_maps_open(struct inode *inode, struct file *file,
 	priv->mm = proc_mem_open(inode, PTRACE_MODE_READ);
 	if (IS_ERR(priv->mm)) {
 		int err = PTR_ERR(priv->mm);
+
 		seq_release_private(inode, file);
 		return err;
 	}

Original file line number	Diff line number	Diff line change
`@@ -225,6 +225,7 @@ static int proc_maps_open(struct inode inode, struct file file,`
`225`	`225`	`priv->mm = proc_mem_open(inode, PTRACE_MODE_READ);`
`226`	`226`	`if (IS_ERR(priv->mm)) {`
`227`	`227`	`int err = PTR_ERR(priv->mm);`
	`228`	`+`
`228`	`229`	`seq_release_private(inode, file);`
`229`	`230`	`return err;`
`230`	`231`	`}`