fix(perf): cloud reporter, calculate insertId correctly so that we don’t loose rows!

tbosch · tbosch · commit 22653707d96a · 2015-01-21T10:40:03.000-08:00
diff --git a/tools/benchpress/src/cloud_reporter.es6 b/tools/benchpress/src/cloud_reporter.es6
@@ -118,7 +118,7 @@ class CloudReporter {
   }
   _convertToTableRow(benchpressRow, stableSample) {
     return {
-      insertId: this.benchmarkConfig.runId+'#'+benchpressRow.index,
+      insertId: this.benchmarkConfig.runId+'#'+this.benchmarkConfig.id+'#'+benchpressRow.index,
       json: {
         runId: this.benchmarkConfig.runId,
         benchmarkId: this.benchmarkConfig.id,

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ class CloudReporter {`
`118`	`118`	`}`
`119`	`119`	`_convertToTableRow(benchpressRow, stableSample) {`
`120`	`120`	`return {`
`121`		`- insertId: this.benchmarkConfig.runId+'#'+benchpressRow.index,`
	`121`	`+ insertId: this.benchmarkConfig.runId+'#'+this.benchmarkConfig.id+'#'+benchpressRow.index,`
`122`	`122`	`json: {`
`123`	`123`	`runId: this.benchmarkConfig.runId,`
`124`	`124`	`benchmarkId: this.benchmarkConfig.id,`