-
Notifications
You must be signed in to change notification settings - Fork 67
Update SymEngine and fix build issues #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
isuruf
commented
Jan 27, 2016
- Remove running of tests in main repo's script
Depends on symengine/symengine#782 |
The changes look good, +1 if tests pass. You should probably update the hash to the latest master. |
All tests pass, except the Sage ones, that it can't find GMP. |
I think we need to set Any ideas how it was finding GMP before? |
@certik, sage issue is because of the new sage archive's naming extracted folder name is different. It's |
I think they use gcc 4.9.2 or so. If there are any compilation issues, then we need to fix them. |
But why cannot we use the old version of Sage for this PR that worked? We can port to new Sage in a new PR. |
Old sage version are not available anymore in the link. Maybe they are archived somewhere |
I can't find it either. That's terrible. |
How is it that this line Line 103 in 9d23ef7
|
We should probably call it without the |
Because |
I tried to fix it in #41, but I think there is an issue with setting Because when installation fails, we should simply fail immediately. |
You can also do |
Except when it fails, then |
Set LD_LIBRARY_PATH to $SAGE_LOCAL. That should fix it. |
Closing in favor of #45. |