Consolidating unnecessary self:: into $this->

chr-hertel · chr-hertel · commit 370fe5e75acb · 2026-04-06T00:41:40.000+02:00
diff --git a/Tests/Completions/ResultConverterTest.php b/Tests/Completions/ResultConverterTest.php
@@ -37,7 +37,7 @@ class ResultConverterTest extends TestCase
     public function testConvertTextResult()
     {
         $converter = new ResultConverter();
-        $httpResponse = self::createMock(ResponseInterface::class);
+        $httpResponse = $this->createMock(ResponseInterface::class);
         $httpResponse->method('toArray')->willReturn([
             'choices' => [
                 [
@@ -59,7 +59,7 @@ public function testConvertTextResult()
     public function testConvertToolWithArgsCallResult()
     {
         $converter = new ResultConverter();
-        $httpResponse = self::createMock(ResponseInterface::class);
+        $httpResponse = $this->createMock(ResponseInterface::class);
         $httpResponse->method('toArray')->willReturn([
             'choices' => [
                 [
@@ -95,7 +95,7 @@ public function testConvertToolWithArgsCallResult()
     public function testConvertToolWithEmptyArgsCallResult()
     {
         $converter = new ResultConverter();
-        $httpResponse = self::createMock(ResponseInterface::class);
+        $httpResponse = $this->createMock(ResponseInterface::class);
         $httpResponse->method('toArray')->willReturn([
             'choices' => [
                 [
@@ -131,7 +131,7 @@ public function testConvertToolWithEmptyArgsCallResult()
     public function testConvertToolWithoutArgsCallResult()
     {
         $converter = new ResultConverter();
-        $httpResponse = self::createMock(ResponseInterface::class);
+        $httpResponse = $this->createMock(ResponseInterface::class);
         $httpResponse->method('toArray')->willReturn([
             'choices' => [
                 [
@@ -166,7 +166,7 @@ public function testConvertToolWithoutArgsCallResult()
     public function testConvertMultipleChoices()
     {
         $converter = new ResultConverter();
-        $httpResponse = self::createMock(ResponseInterface::class);
+        $httpResponse = $this->createMock(ResponseInterface::class);
         $httpResponse->method('toArray')->willReturn([
             'choices' => [
                 [
@@ -198,7 +198,7 @@ public function testConvertMultipleChoices()
     public function testContentFilterException()
     {
         $converter = new ResultConverter();
-        $httpResponse = self::createMock(ResponseInterface::class);
+        $httpResponse = $this->createMock(ResponseInterface::class);
 
         $httpResponse->expects($this->exactly(1))
             ->method('toArray')
@@ -229,7 +229,7 @@ public function getResponse(): ResponseInterface
     public function testThrowsAuthenticationExceptionOnInvalidApiKey()
     {
         $converter = new ResultConverter();
-        $httpResponse = self::createMock(ResponseInterface::class);
+        $httpResponse = $this->createMock(ResponseInterface::class);
         $httpResponse->method('getStatusCode')->willReturn(401);
         $httpResponse->method('getContent')->willReturn(json_encode([
             'error' => [
@@ -246,7 +246,7 @@ public function testThrowsAuthenticationExceptionOnInvalidApiKey()
     public function testThrowsExceptionWhenNoChoices()
     {
         $converter = new ResultConverter();
-        $httpResponse = self::createMock(ResponseInterface::class);
+        $httpResponse = $this->createMock(ResponseInterface::class);
         $httpResponse->method('toArray')->willReturn([]);
 
         $this->expectException(RuntimeException::class);
@@ -258,7 +258,7 @@ public function testThrowsExceptionWhenNoChoices()
     public function testThrowsExceptionForUnsupportedFinishReason()
     {
         $converter = new ResultConverter();
-        $httpResponse = self::createMock(ResponseInterface::class);
+        $httpResponse = $this->createMock(ResponseInterface::class);
         $httpResponse->method('toArray')->willReturn([
             'choices' => [
                 [
@@ -280,7 +280,7 @@ public function testThrowsExceptionForUnsupportedFinishReason()
     public function testThrowsBadRequestExceptionOnBadRequestResponse()
     {
         $converter = new ResultConverter();
-        $httpResponse = self::createMock(ResponseInterface::class);
+        $httpResponse = $this->createMock(ResponseInterface::class);
         $httpResponse->method('getStatusCode')->willReturn(400);
         $httpResponse->method('getContent')->willReturn(json_encode([
             'error' => [
@@ -297,7 +297,7 @@ public function testThrowsBadRequestExceptionOnBadRequestResponse()
     public function testThrowsBadRequestExceptionOnBadRequestResponseWithNoResponseBody()
     {
         $converter = new ResultConverter();
-        $httpResponse = self::createMock(ResponseInterface::class);
+        $httpResponse = $this->createMock(ResponseInterface::class);
         $httpResponse->method('getStatusCode')->willReturn(400);
 
         $this->expectException(BadRequestException::class);
@@ -309,7 +309,7 @@ public function testThrowsBadRequestExceptionOnBadRequestResponseWithNoResponseB
     public function testThrowsDetailedErrorException()
     {
         $converter = new ResultConverter();
-        $httpResponse = self::createMock(ResponseInterface::class);
+        $httpResponse = $this->createMock(ResponseInterface::class);
         $httpResponse->method('toArray')->willReturn([
             'error' => [
                 'code' => 'invalid_request_error',

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ class ResultConverterTest extends TestCase`
`37`	`37`	`public function testConvertTextResult()`
`38`	`38`	`{`
`39`	`39`	`$converter = new ResultConverter();`
`40`		`- $httpResponse = self::createMock(ResponseInterface::class);`
	`40`	`+ $httpResponse = $this->createMock(ResponseInterface::class);`
`41`	`41`	`$httpResponse->method('toArray')->willReturn([`
`42`	`42`	`'choices' => [`
`43`	`43`	`[`
`@@ -59,7 +59,7 @@ public function testConvertTextResult()`
`59`	`59`	`public function testConvertToolWithArgsCallResult()`
`60`	`60`	`{`
`61`	`61`	`$converter = new ResultConverter();`
`62`		`- $httpResponse = self::createMock(ResponseInterface::class);`
	`62`	`+ $httpResponse = $this->createMock(ResponseInterface::class);`
`63`	`63`	`$httpResponse->method('toArray')->willReturn([`
`64`	`64`	`'choices' => [`
`65`	`65`	`[`
`@@ -95,7 +95,7 @@ public function testConvertToolWithArgsCallResult()`
`95`	`95`	`public function testConvertToolWithEmptyArgsCallResult()`
`96`	`96`	`{`
`97`	`97`	`$converter = new ResultConverter();`
`98`		`- $httpResponse = self::createMock(ResponseInterface::class);`
	`98`	`+ $httpResponse = $this->createMock(ResponseInterface::class);`
`99`	`99`	`$httpResponse->method('toArray')->willReturn([`
`100`	`100`	`'choices' => [`
`101`	`101`	`[`
`@@ -131,7 +131,7 @@ public function testConvertToolWithEmptyArgsCallResult()`
`131`	`131`	`public function testConvertToolWithoutArgsCallResult()`
`132`	`132`	`{`
`133`	`133`	`$converter = new ResultConverter();`
`134`		`- $httpResponse = self::createMock(ResponseInterface::class);`
	`134`	`+ $httpResponse = $this->createMock(ResponseInterface::class);`
`135`	`135`	`$httpResponse->method('toArray')->willReturn([`
`136`	`136`	`'choices' => [`
`137`	`137`	`[`
`@@ -166,7 +166,7 @@ public function testConvertToolWithoutArgsCallResult()`
`166`	`166`	`public function testConvertMultipleChoices()`
`167`	`167`	`{`
`168`	`168`	`$converter = new ResultConverter();`
`169`		`- $httpResponse = self::createMock(ResponseInterface::class);`
	`169`	`+ $httpResponse = $this->createMock(ResponseInterface::class);`
`170`	`170`	`$httpResponse->method('toArray')->willReturn([`
`171`	`171`	`'choices' => [`
`172`	`172`	`[`
`@@ -198,7 +198,7 @@ public function testConvertMultipleChoices()`
`198`	`198`	`public function testContentFilterException()`
`199`	`199`	`{`
`200`	`200`	`$converter = new ResultConverter();`
`201`		`- $httpResponse = self::createMock(ResponseInterface::class);`
	`201`	`+ $httpResponse = $this->createMock(ResponseInterface::class);`
`202`	`202`
`203`	`203`	`$httpResponse->expects($this->exactly(1))`
`204`	`204`	`->method('toArray')`
`@@ -229,7 +229,7 @@ public function getResponse(): ResponseInterface`
`229`	`229`	`public function testThrowsAuthenticationExceptionOnInvalidApiKey()`
`230`	`230`	`{`
`231`	`231`	`$converter = new ResultConverter();`
`232`		`- $httpResponse = self::createMock(ResponseInterface::class);`
	`232`	`+ $httpResponse = $this->createMock(ResponseInterface::class);`
`233`	`233`	`$httpResponse->method('getStatusCode')->willReturn(401);`
`234`	`234`	`$httpResponse->method('getContent')->willReturn(json_encode([`
`235`	`235`	`'error' => [`
`@@ -246,7 +246,7 @@ public function testThrowsAuthenticationExceptionOnInvalidApiKey()`
`246`	`246`	`public function testThrowsExceptionWhenNoChoices()`
`247`	`247`	`{`
`248`	`248`	`$converter = new ResultConverter();`
`249`		`- $httpResponse = self::createMock(ResponseInterface::class);`
	`249`	`+ $httpResponse = $this->createMock(ResponseInterface::class);`
`250`	`250`	`$httpResponse->method('toArray')->willReturn([]);`
`251`	`251`
`252`	`252`	`$this->expectException(RuntimeException::class);`
`@@ -258,7 +258,7 @@ public function testThrowsExceptionWhenNoChoices()`
`258`	`258`	`public function testThrowsExceptionForUnsupportedFinishReason()`
`259`	`259`	`{`
`260`	`260`	`$converter = new ResultConverter();`
`261`		`- $httpResponse = self::createMock(ResponseInterface::class);`
	`261`	`+ $httpResponse = $this->createMock(ResponseInterface::class);`
`262`	`262`	`$httpResponse->method('toArray')->willReturn([`
`263`	`263`	`'choices' => [`
`264`	`264`	`[`
`@@ -280,7 +280,7 @@ public function testThrowsExceptionForUnsupportedFinishReason()`
`280`	`280`	`public function testThrowsBadRequestExceptionOnBadRequestResponse()`
`281`	`281`	`{`
`282`	`282`	`$converter = new ResultConverter();`
`283`		`- $httpResponse = self::createMock(ResponseInterface::class);`
	`283`	`+ $httpResponse = $this->createMock(ResponseInterface::class);`
`284`	`284`	`$httpResponse->method('getStatusCode')->willReturn(400);`
`285`	`285`	`$httpResponse->method('getContent')->willReturn(json_encode([`
`286`	`286`	`'error' => [`
`@@ -297,7 +297,7 @@ public function testThrowsBadRequestExceptionOnBadRequestResponse()`
`297`	`297`	`public function testThrowsBadRequestExceptionOnBadRequestResponseWithNoResponseBody()`
`298`	`298`	`{`
`299`	`299`	`$converter = new ResultConverter();`
`300`		`- $httpResponse = self::createMock(ResponseInterface::class);`
	`300`	`+ $httpResponse = $this->createMock(ResponseInterface::class);`
`301`	`301`	`$httpResponse->method('getStatusCode')->willReturn(400);`
`302`	`302`
`303`	`303`	`$this->expectException(BadRequestException::class);`
`@@ -309,7 +309,7 @@ public function testThrowsBadRequestExceptionOnBadRequestResponseWithNoResponseB`
`309`	`309`	`public function testThrowsDetailedErrorException()`
`310`	`310`	`{`
`311`	`311`	`$converter = new ResultConverter();`
`312`		`- $httpResponse = self::createMock(ResponseInterface::class);`
	`312`	`+ $httpResponse = $this->createMock(ResponseInterface::class);`
`313`	`313`	`$httpResponse->method('toArray')->willReturn([`
`314`	`314`	`'error' => [`
`315`	`315`	`'code' => 'invalid_request_error',`