[Platform][Generic][Scaleway] Fix tool call without arguments

guillaume-ro-fr · chr-hertel · commit ae0b77c1807e · 2026-03-22T23:52:30.000+01:00
diff --git a/Completions/CompletionsConversionTrait.php b/Completions/CompletionsConversionTrait.php
@@ -70,7 +70,13 @@ protected function convertStreamToToolCalls(array $toolCalls, array $data): arra
             }
 
             // add arguments delta to tool call
-            $toolCalls[$i]['function']['arguments'] .= $toolCall['function']['arguments'];
+            if (isset($toolCall['function']['arguments'])) {
+                if (!isset($toolCalls[$i]['function']['arguments'])) {
+                    $toolCalls[$i]['function']['arguments'] = '';
+                }
+
+                $toolCalls[$i]['function']['arguments'] .= $toolCall['function']['arguments'];
+            }
         }
 
         return $toolCalls;
@@ -131,13 +137,17 @@ protected function convertChoice(array $choice): ToolCallResult|TextResult
      *     type: 'function',
      *     function: array{
      *         name: string,
-     *         arguments: string
+     *         arguments?: string
      *     }
      * } $toolCall
      */
     protected function convertToolCall(array $toolCall): ToolCall
     {
-        $arguments = json_decode($toolCall['function']['arguments'], true, flags: \JSON_THROW_ON_ERROR);
+        if (isset($toolCall['function']['arguments']) && '' !== $toolCall['function']['arguments']) {
+            $arguments = json_decode($toolCall['function']['arguments'], true, flags: \JSON_THROW_ON_ERROR);
+        } else {
+            $arguments = [];
+        }
 
         return new ToolCall($toolCall['id'], $toolCall['function']['name'], $arguments);
     }
diff --git a/Tests/Completions/ResultConverterTest.php b/Tests/Completions/ResultConverterTest.php
@@ -48,7 +48,7 @@ public function testConvertTextResult()
         $this->assertSame('Hello world', $result->getContent());
     }
 
-    public function testConvertToolCallResult()
+    public function testConvertToolWithArgsCallResult()
     {
         $converter = new ResultConverter();
         $httpResponse = self::createMock(ResponseInterface::class);
@@ -84,6 +84,77 @@ public function testConvertToolCallResult()
         $this->assertSame(['arg1' => 'value1'], $toolCalls[0]->getArguments());
     }
 
+    public function testConvertToolWithEmptyArgsCallResult()
+    {
+        $converter = new ResultConverter();
+        $httpResponse = self::createMock(ResponseInterface::class);
+        $httpResponse->method('toArray')->willReturn([
+            'choices' => [
+                [
+                    'message' => [
+                        'role' => 'assistant',
+                        'content' => null,
+                        'tool_calls' => [
+                            [
+                                'id' => 'call_123',
+                                'type' => 'function',
+                                'function' => [
+                                    'name' => 'test_function',
+                                    'arguments' => '',
+                                ],
+                            ],
+                        ],
+                    ],
+                    'finish_reason' => 'tool_calls',
+                ],
+            ],
+        ]);
+
+        $result = $converter->convert(new RawHttpResult($httpResponse));
+
+        $this->assertInstanceOf(ToolCallResult::class, $result);
+        $toolCalls = $result->getContent();
+        $this->assertCount(1, $toolCalls);
+        $this->assertSame('call_123', $toolCalls[0]->getId());
+        $this->assertSame('test_function', $toolCalls[0]->getName());
+        $this->assertSame([], $toolCalls[0]->getArguments());
+    }
+
+    public function testConvertToolWithoutArgsCallResult()
+    {
+        $converter = new ResultConverter();
+        $httpResponse = self::createMock(ResponseInterface::class);
+        $httpResponse->method('toArray')->willReturn([
+            'choices' => [
+                [
+                    'message' => [
+                        'role' => 'assistant',
+                        'content' => null,
+                        'tool_calls' => [
+                            [
+                                'id' => 'call_123',
+                                'type' => 'function',
+                                'function' => [
+                                    'name' => 'test_function',
+                                ],
+                            ],
+                        ],
+                    ],
+                    'finish_reason' => 'tool_calls',
+                ],
+            ],
+        ]);
+
+        $result = $converter->convert(new RawHttpResult($httpResponse));
+
+        $this->assertInstanceOf(ToolCallResult::class, $result);
+        $toolCalls = $result->getContent();
+        $this->assertCount(1, $toolCalls);
+        $this->assertSame('call_123', $toolCalls[0]->getId());
+        $this->assertSame('test_function', $toolCalls[0]->getName());
+        $this->assertSame([], $toolCalls[0]->getArguments());
+    }
+
     public function testConvertMultipleChoices()
     {
         $converter = new ResultConverter();
