[Asset] improve performance of UrlPackage::chooseBaseUrl()

kbond · frankdejonge · kbond · commit a0ebf67f56f0 · 2022-10-19T12:13:28.000-04:00
Co-authored-by: Frank de Jonge &lt;frankdejonge@users.noreply.github.com&gt;
diff --git a/Tests/UrlPackageTest.php b/Tests/UrlPackageTest.php
@@ -48,10 +48,10 @@ public function getConfigs()
             ['file:///example/com/foo/', '', 'foo', 'file:///example/com/foo/foo?v1'],
 
             [['http://example.com'], '', '/foo', 'http://example.com/foo?v1'],
-            [['http://example.com', 'http://example.net'], '', '/foo', 'http://example.com/foo?v1'],
-            [['http://example.com', 'http://example.net'], '', '/fooa', 'http://example.net/fooa?v1'],
-            [['file:///example/com', 'file:///example/net'], '', '/foo', 'file:///example/com/foo?v1'],
-            [['ftp://example.com', 'ftp://example.net'], '', '/fooa', 'ftp://example.net/fooa?v1'],
+            [['http://example.com', 'http://example.net'], '', '/foo', 'http://example.net/foo?v1'],
+            [['http://example.com', 'http://example.net'], '', '/fooa', 'http://example.com/fooa?v1'],
+            [['file:///example/com', 'file:///example/net'], '', '/foo', 'file:///example/net/foo?v1'],
+            [['ftp://example.com', 'ftp://example.net'], '', '/fooa', 'ftp://example.com/fooa?v1'],
 
             ['http://example.com', 'version-%2$s/%1$s', '/foo', 'http://example.com/version-v1/foo'],
             ['http://example.com', 'version-%2$s/%1$s', 'foo', 'http://example.com/version-v1/foo'],
@@ -77,15 +77,16 @@ public function getContextConfigs()
         return [
             [false, 'http://example.com', '', 'foo', 'http://example.com/foo?v1'],
             [false, ['http://example.com'], '', 'foo', 'http://example.com/foo?v1'],
-            [false, ['http://example.com', 'https://example.com'], '', 'foo', 'http://example.com/foo?v1'],
-            [false, ['http://example.com', 'https://example.com'], '', 'fooa', 'https://example.com/fooa?v1'],
+            [false, ['http://example.com', 'https://example.com'], '', 'foo', 'https://example.com/foo?v1'],
+            [false, ['http://example.com', 'https://example.com'], '', 'fooa', 'http://example.com/fooa?v1'],
             [false, ['http://example.com/bar'], '', 'foo', 'http://example.com/bar/foo?v1'],
             [false, ['http://example.com/bar/'], '', 'foo', 'http://example.com/bar/foo?v1'],
             [false, ['//example.com/bar/'], '', 'foo', '//example.com/bar/foo?v1'],
 
             [true, ['http://example.com'], '', 'foo', 'http://example.com/foo?v1'],
             [true, ['http://example.com', 'https://example.com'], '', 'foo', 'https://example.com/foo?v1'],
-            [true, ['', 'https://example.com'], '', 'foo', '/foo?v1'],
+            [true, ['', 'https://example.com'], '', 'foo', 'https://example.com/foo?v1'],
+            [true, ['', 'https://example.com'], '', 'bar', '/bar?v1'],
         ];
     }
 
diff --git a/UrlPackage.php b/UrlPackage.php
@@ -107,7 +107,7 @@ public function getBaseUrl(string $path): string
      */
     protected function chooseBaseUrl(string $path): int
     {
-        return (int) fmod(hexdec(substr(hash('sha256', $path), 0, 10)), \count($this->baseUrls));
+        return abs(crc32($path)) % \count($this->baseUrls);
     }
 
     private function getSslUrls(array $urls)

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ public function getBaseUrl(string $path): string`
`107`	`107`	`*/`
`108`	`108`	`protected function chooseBaseUrl(string $path): int`
`109`	`109`	`{`
`110`		`- return (int) fmod(hexdec(substr(hash('sha256', $path), 0, 10)), \count($this->baseUrls));`
	`110`	`+ return abs(crc32($path)) % \count($this->baseUrls);`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`private function getSslUrls(array $urls)`