Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 7113778

Browse files
Merge branch '7.4' into 8.0
* 7.4: (23 commits) [Form] Preserve collection children added by PRE_SET_DATA listeners [Messenger] Keep deduplication lock when handler throws [Mailer][Postmark] Handle alternate error payload shapes for Payload Too Large CS fix [Serializer] Catch TypeError when setting an attribute to collect denormalization errors [Config] Allow env placeholders in NumericNode min/max checks [Mime] Preserve inline part filename instead of overwriting it with the Content-ID [FrameworkBundle] Apply tagged MIME type guessers in File::getMimeType() [Notifier] [Ntfy] Fix Basic auth header by keeping base64 padding [MonologBridge] Guard against re-entrant calls in AbstractTokenProcessor [RateLimiter] Keep token bucket alive while reservation debt is unpaid [Lock] Avoid aborting outer PostgreSQL transaction on lock contention [HttpClient] Don't share CURL_LOCK_DATA_CONNECT to honor max_host_connections [Validator] fix mapping properties using property hooks [DoctrineBridge] Fail with a clear exception when symfony/form is missing [DoctrineBridge] Prevent install with incompatible symfony/property-info versions [AssetMapper] Allow spaces in version constraints [Dotenv] Strip NUL byte placeholder from values passed to `putenv()` [Cache] Normalize default_lifetime for pools wrapped by ChainAdapter [Config] Fix array-shape generator dropping alternative types on nested PrototypedArrayNode ... # Conflicts: # src/Symfony/Bridge/Doctrine/Tests/Types/DatePointTypeTest.php # src/Symfony/Bridge/Doctrine/Tests/Types/UlidTypeTest.php # src/Symfony/Component/DependencyInjection/Tests/Compiler/RegisterServiceSubscribersPassTest.php # src/Symfony/Component/Form/Extension/Core/EventListener/ResizeFormListener.php # src/Symfony/Component/JsonStreamer/Tests/JsonStreamReaderTest.php # src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php # src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpStanExtractorTest.php # src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php # src/Symfony/Component/Serializer/Tests/Normalizer/PropertyNormalizerTest.php # src/Symfony/Component/TypeInfo/Tests/TypeFactoryTest.php
2 parents a4f377d + d7d2b64 commit 7113778

5 files changed

Lines changed: 7 additions & 7 deletions

File tree

Tests/ApplicationTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2485,7 +2485,7 @@ public function testAlarmSubscriberNotCalledForOtherSignals()
24852485
#[RequiresPhpExtension('pcntl')]
24862486
public function testAlarmSubscriber()
24872487
{
2488-
$command = new BaseSignableCommand(signal: \SIGALRM);
2488+
$command = new BaseSignableCommand(true, \SIGALRM);
24892489

24902490
$subscriber1 = new AlarmEventSubscriber();
24912491
$subscriber2 = new AlarmEventSubscriber();
@@ -2703,7 +2703,7 @@ public function testsPreservedHelpOptionWhenItsAnAlternative()
27032703
#[TestWith([4])]
27042704
public function testAlarmSubscriberCalledAfterSignalSubscriberAndInheritsExitCode(int|false $exitCode)
27052705
{
2706-
$command = new BaseSignableCommand(signal: \SIGALRM);
2706+
$command = new BaseSignableCommand(true, \SIGALRM);
27072707

27082708
$subscriber1 = new class($exitCode) extends SignalEventSubscriber {
27092709
public function __construct(private int|false $exitCode)

Tests/Command/CompleteCommandTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ protected function setUp(): void
3737
$this->application = new Application();
3838
$this->application->addCommand(new CompleteCommandTest_HelloCommand());
3939
$this->application->getDefinition()
40-
->addOption(new InputOption('global-option', null, InputOption::VALUE_REQUIRED, suggestedValues: ['foo', 'bar', 'baz']));
40+
->addOption(new InputOption('global-option', null, InputOption::VALUE_REQUIRED, '', null, ['foo', 'bar', 'baz']));
4141

4242
$this->command->setApplication($this->application);
4343
$this->tester = new CommandTester($this->command);

Tests/Exception/RunCommandFailedExceptionTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ private static function createException(\Throwable $inner): RunCommandFailedExce
4141
$inner,
4242
new RunCommandContext(
4343
new RunCommandMessage('foo'),
44-
exitCode: Command::FAILURE,
45-
output: 'bar'
44+
Command::FAILURE,
45+
'bar'
4646
)
4747
);
4848
}

Tests/Fixtures/application_test_sigint.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
(new class extends Command {
1919
protected function configure(): void
2020
{
21-
$this->addArgument('mode', InputArgument::OPTIONAL, default: 'single');
21+
$this->addArgument('mode', InputArgument::OPTIONAL, '', 'single');
2222
}
2323

2424
protected function execute(InputInterface $input, OutputInterface $output): int

Tests/Messenger/RunCommandMessageHandlerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public function testExecutesCommandThatThrowsException()
6060
public function testExecutesCommandThatCatchesThrownException()
6161
{
6262
$handler = new RunCommandMessageHandler($this->createApplicationWithCommand());
63-
$context = $handler(new RunCommandMessage('test:command --throw -v', throwOnFailure: false, catchExceptions: true));
63+
$context = $handler(new RunCommandMessage('test:command --throw -v', false, true));
6464

6565
$this->assertSame(1, $context->exitCode);
6666
$this->assertStringContainsString('[RuntimeException]', $context->output);

0 commit comments

Comments
 (0)