Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit fc5fd0d

Browse files
committed
Merge branch '6.4' into 7.2
* 6.4: add back setAccessible() for PHP 7 compatibility Update BrevoRequestParser.php [Form][PhpUnitBridge] Remove usage of noop `ReflectionProperty::setAccessible()` fix compatibility with different Relay versions [Console] Fix JSON description for negatable input flags
2 parents 6f888fb + 795dd19 commit fc5fd0d

3 files changed

Lines changed: 13 additions & 14 deletions

File tree

Descriptor/JsonDescriptor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ private function getInputOptionData(InputOption $option, bool $negated = false):
108108
'is_value_required' => false,
109109
'is_multiple' => false,
110110
'description' => 'Negate the "--'.$option->getName().'" option',
111-
'default' => false,
111+
'default' => null === $option->getDefault() ? null : !$option->getDefault(),
112112
] : [
113113
'name' => '--'.$option->getName(),
114114
'shortcut' => $option->getShortcut() ? '-'.str_replace('|', '|-', $option->getShortcut()) : '',

Tests/Descriptor/JsonDescriptorTest.php

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,9 @@ private function normalizeOutputRecursively($output)
3636
return array_map($this->normalizeOutputRecursively(...), $output);
3737
}
3838

39-
if (null === $output) {
40-
return null;
41-
}
42-
43-
return parent::normalizeOutput($output);
39+
return match ($output) {
40+
null, true, false => $output,
41+
default => parent::normalizeOutput($output),
42+
};
4443
}
4544
}

Tests/Fixtures/application_2.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@
9494
"is_value_required": false,
9595
"is_multiple": false,
9696
"description": "Do not ask any interactive question",
97-
"default": false
97+
"default": null
9898
},
9999
"shell": {
100100
"name": "--shell",
@@ -224,7 +224,7 @@
224224
"is_value_required": false,
225225
"is_multiple": false,
226226
"description": "Do not ask any interactive question",
227-
"default": false
227+
"default": null
228228
},
229229
"debug": {
230230
"name": "--debug",
@@ -345,7 +345,7 @@
345345
"is_value_required": false,
346346
"is_multiple": false,
347347
"description": "Do not ask any interactive question",
348-
"default": false
348+
"default": null
349349
}
350350
}
351351
}
@@ -457,7 +457,7 @@
457457
"is_value_required": false,
458458
"is_multiple": false,
459459
"description": "Do not ask any interactive question",
460-
"default": false
460+
"default": null
461461
},
462462
"short": {
463463
"name": "--short",
@@ -554,7 +554,7 @@
554554
"is_value_required": false,
555555
"is_multiple": false,
556556
"description": "Do not ask any interactive question",
557-
"default": false
557+
"default": null
558558
}
559559
}
560560
}
@@ -659,7 +659,7 @@
659659
"is_value_required": false,
660660
"is_multiple": false,
661661
"description": "Do not ask any interactive question",
662-
"default": false
662+
"default": null
663663
}
664664
}
665665
}
@@ -745,7 +745,7 @@
745745
"is_value_required": false,
746746
"is_multiple": false,
747747
"description": "Do not ask any interactive question",
748-
"default": false
748+
"default": null
749749
}
750750
}
751751
}
@@ -833,7 +833,7 @@
833833
"is_value_required": false,
834834
"is_multiple": false,
835835
"description": "Do not ask any interactive question",
836-
"default": false
836+
"default": null
837837
}
838838
}
839839
}

0 commit comments

Comments
 (0)