Remove unused code and unnecessary else branches

alexandre-daubois · alexandre-daubois · commit 966f1900ef07 · 2024-08-02T08:50:04.000+02:00
diff --git a/Dotenv.php b/Dotenv.php
@@ -485,7 +485,7 @@ private function resolveVariables(string $value, array $loadedVars): string
             (?P<closing_brace>\})?             # optional closing brace
         /x';
 
-        $value = preg_replace_callback($regex, function ($matches) use ($loadedVars) {
+        return preg_replace_callback($regex, function ($matches) use ($loadedVars) {
             // odd number of backslashes means the $ character is escaped
             if (1 === \strlen($matches['backslashes']) % 2) {
                 return substr($matches[0], 1);
@@ -532,8 +532,6 @@ private function resolveVariables(string $value, array $loadedVars): string
 
             return $matches['backslashes'].$value;
         }, $value);
-
-        return $value;
     }
 
     private function moveCursor(string $text): void
