-
-
Notifications
You must be signed in to change notification settings - Fork 95
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: symfony/http-kernel
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.4.47
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: symfony/http-kernel
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.4.48
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 6 commits
- 5 files changed
- 4 contributors
Commits on Oct 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d84ce93 - Browse repository at this point
Copy the full SHA d84ce93View commit details
Commits on Oct 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for abc1357 - Browse repository at this point
Copy the full SHA abc1357View commit details -
bug #47878 [HttpKernel] Remove EOL when using error_log() in HttpKern…
…el Logger (cyve) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [HttpKernel] Remove EOL when using error_log() in HttpKernel Logger | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | maybe | Tickets | | License | MIT | Doc PR | Hello there ! Since PR symfony/symfony#36855, when using `Symfony\Component\HttpKernel\Log\Logger` with argument `$output = null`. The logger use the `error_log()` method to log messages. But in the log file, messages are separated by an empty line because the default formatter (`Logger::format()`) adds an extra EOL char at the end of the message. This fix prevents the logger to add an extra EOL char when it uses `error_log()`. Possible BC : if someone use the logger with a custom formatter that already add a EOL char at the end of the message, there will be a empty line between messages in the log file. In my opinion, this is minor enough not to worry about it ;-) Thanks for your review :-) Commits ------- 69cf83ea1a [HttpKernel] Remove EOL when using error_log() in HttpKernel Logger
Configuration menu - View commit details
-
Copy full SHA for 9a34f1a - Browse repository at this point
Copy the full SHA 9a34f1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f61170 - Browse repository at this point
Copy the full SHA 3f61170View commit details -
bug #47857 [HttpKernel] Fix empty request stack when terminating with…
… exception (krzyc) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [HttpKernel] Fix empty request stack when terminating with exception | Q | A | ------------- | --- | Branch? | 4.4, 5.4, 6.0, 6.1, 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #47577 | License | MIT | Doc PR | After symfony/symfony#47358 the RequestStack is empty when request terminates with exception, which prevents SecurityDataCollector to generate logout URL and generates fatal error. Commits ------- e4d6e7b4ba [HttpKernel] Fix empty request stack when terminating with exception
Configuration menu - View commit details
-
Copy full SHA for 26989b2 - Browse repository at this point
Copy the full SHA 26989b2View commit details
Commits on Oct 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a6d5229 - Browse repository at this point
Copy the full SHA a6d5229View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v4.4.47...v4.4.48