Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/mailer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.1.0-RC1
Choose a base ref
...
head repository: symfony/mailer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.1.0
Choose a head ref
  • 5 commits
  • 4 files changed
  • 2 contributors

Commits on May 30, 2024

  1. Configuration menu
    Copy the full SHA
    1c39471 View commit details
    Browse the repository at this point in the history
  2. bug #54572 [Mailer] Fix sendmail transport failure handling and inter…

    …active mode (bobvandevijver)
    
    This PR was squashed before being merged into the 5.4 branch.
    
    Discussion
    ----------
    
    [Mailer] Fix sendmail transport failure handling and interactive mode
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 5.4
    | Bug fix?      | yes
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Issues        | Fix #54532 <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->
    | License       | MIT
    
    #54239 introduced an issue for us when using sendmail in interactive mode using a long running background worker. It will throw exceptions due to an unclean shutdown in case of an SMTP timeout (5 minute by default), while in interactive mode all output is actually handled by the SMTP transport, including that timeout. That makes the exit code of the long running process not relevant in that mode. See the bug report for some more details.
    
    I have verified that this change solves my production issues, although I am not particularly fond on the hoops I had to jump to show this in the test.
    
    cc `@aboks`
    
    Commits
    -------
    
    1b2ead35ca [Mailer] Fix sendmail transport failure handling and interactive mode
    fabpot committed May 30, 2024
    Configuration menu
    Copy the full SHA
    31d6641 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Merge branch '5.4' into 6.4

    * 5.4:
      [Mailer] Fix sendmail transport failure handling and interactive mode
      [Security] reviewed Romanian translation of key 20
    fabpot committed May 31, 2024
    Configuration menu
    Copy the full SHA
    928a8d6 View commit details
    Browse the repository at this point in the history
  2. Merge branch '6.4' into 7.0

    * 6.4:
      [Mailer] Fix sendmail transport failure handling and interactive mode
      [Security] reviewed Romanian translation of key 20
    fabpot committed May 31, 2024
    Configuration menu
    Copy the full SHA
    08b059f View commit details
    Browse the repository at this point in the history
  3. Merge branch '7.0' into 7.1

    * 7.0:
      [Mailer] Fix sendmail transport failure handling and interactive mode
      [Security] reviewed Romanian translation of key 20
    fabpot committed May 31, 2024
    Configuration menu
    Copy the full SHA
    1528f3f View commit details
    Browse the repository at this point in the history
Loading