[make:*] upgrade bundled php-cs-fixer to version 3.49.0

jrushlow · jrushlow · commit 9712fe79a7cf · 2024-02-07T05:27:16.000-05:00
diff --git a/src/Resources/bin/php-cs-fixer-v3.49.0.phar b/src/Resources/bin/php-cs-fixer-v3.49.0.phar
diff --git a/src/Util/TemplateLinter.php b/src/Util/TemplateLinter.php
@@ -25,6 +25,9 @@
  */
 final class TemplateLinter
 {
+    // Version must match bundled version file name. e.g. php-cs-fixer-v3.49.9.phar
+    public const BUNDLED_PHP_CS_FIXER_VERSION = '3.49.0';
+
     private bool $usingBundledPhpCsFixer = true;
     private bool $usingBundledPhpCsFixerConfig = true;
     private bool $needsPhpCmdPrefix = true;
@@ -96,7 +99,7 @@ private function setBinary(): void
     {
         // Use Bundled PHP-CS-Fixer
         if (null === $this->phpCsFixerBinaryPath) {
-            $this->phpCsFixerBinaryPath = \dirname(__DIR__).'/Resources/bin/php-cs-fixer-v3.13.0.phar';
+            $this->phpCsFixerBinaryPath = sprintf('%s/Resources/bin/php-cs-fixer-v%s.phar', \dirname(__DIR__), self::BUNDLED_PHP_CS_FIXER_VERSION);
 
             return;
         }
diff --git a/tests/Util/TemplateLinterTest.php b/tests/Util/TemplateLinterTest.php
@@ -13,6 +13,7 @@
 
 use PHPUnit\Framework\TestCase;
 use Symfony\Bundle\MakerBundle\Util\TemplateLinter;
+use Symfony\Component\Process\Process;
 
 /**
  * Linter tests are written in `tests/Maker/TemplateLinterTest`.
@@ -36,4 +37,15 @@ public function testExceptionThrownIfConfigPathDoesntExist(): void
 
         new TemplateLinter(phpCsFixerConfigPath: '/bad/config/path');
     }
+
+    public function testPhpCsFixerVersion(): void
+    {
+        $fixerPath = sprintf('%s/src/Resources/bin/php-cs-fixer-v%s.phar', dirname(__DIR__, 2), TemplateLinter::BUNDLED_PHP_CS_FIXER_VERSION);
+
+        $process = Process::fromShellCommandline(sprintf('PHP_CS_FIXER_IGNORE_ENV=1 %s -V', $fixerPath));
+
+        $process->run();
+
+        self::assertStringContainsString(TemplateLinter::BUNDLED_PHP_CS_FIXER_VERSION, $process->getOutput());
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,9 @@`
`25`	`25`	`*/`
`26`	`26`	`final class TemplateLinter`
`27`	`27`	`{`
	`28`	`+ // Version must match bundled version file name. e.g. php-cs-fixer-v3.49.9.phar`
	`29`	`+ public const BUNDLED_PHP_CS_FIXER_VERSION = '3.49.0';`
	`30`	`+`
`28`	`31`	`private bool $usingBundledPhpCsFixer = true;`
`29`	`32`	`private bool $usingBundledPhpCsFixerConfig = true;`
`30`	`33`	`private bool $needsPhpCmdPrefix = true;`
`@@ -96,7 +99,7 @@ private function setBinary(): void`
`96`	`99`	`{`
`97`	`100`	`// Use Bundled PHP-CS-Fixer`
`98`	`101`	`if (null === $this->phpCsFixerBinaryPath) {`
`99`		`- $this->phpCsFixerBinaryPath = \dirname(__DIR__).'/Resources/bin/php-cs-fixer-v3.13.0.phar';`
	`102`	`+ $this->phpCsFixerBinaryPath = sprintf('%s/Resources/bin/php-cs-fixer-v%s.phar', \dirname(__DIR__), self::BUNDLED_PHP_CS_FIXER_VERSION);`
`100`	`103`
`101`	`104`	`return;`
`102`	`105`	`}`