[Process] Fixed inconsistent test

amne · amne · commit 175925109fa5 · 2024-01-13T01:09:26.000+02:00
Sometimes the process no longer appears to be running when the signal is sent which causes a LogicException to be thrown.
This doesn't appear to be consistent and I can reproduce it randomly on my local machine. To avoid having tests fail at random
I decided that it's better to send the signal only if the process is still marked as running.
diff --git a/Tests/ErrorProcessInitiator.php b/Tests/ErrorProcessInitiator.php
@@ -25,7 +25,7 @@
     while (!str_contains($process->getOutput(), 'ready')) {
         usleep(1000);
     }
-    $process->signal(\SIGSTOP);
+    $process->isRunning() && $process->signal(\SIGSTOP);
     $process->wait();
 
     return $process->getExitCode();

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@`
`25`	`25`	`while (!str_contains($process->getOutput(), 'ready')) {`
`26`	`26`	`usleep(1000);`
`27`	`27`	`}`
`28`		`- $process->signal(\SIGSTOP);`
	`28`	`+ $process->isRunning() && $process->signal(\SIGSTOP);`
`29`	`29`	`$process->wait();`
`30`	`30`
`31`	`31`	`return $process->getExitCode();`