Merge branch '6.4' into 7.0

derrabus · derrabus · commit b7004dc4b651 · 2023-07-30T11:45:37.000+02:00
* 6.4: (99 commits)
  [HttpClient][Messenger] add `PingWebhookMessage` and `PingWebhookMessageHandler`
  Use Stringable interface as much as possible
  [Messenger][Process] add `RunProcessMessage` and `RunProcessMessageHandler`
  Add generics to the progress bar iteration methods
  [SecurityBundle] Allow an array of `pattern` in firewall configuration
  [FrameworkBundle] Simplify marking store configuration
  [PsrHttpMessageBridge] Patch return types and fix CS
  [PsrHttpMessageBridge] Import the bridge into the monorepo
  Prepare release 2.3.1
  Fix CS
  Don't rely on Request::getPayload() to populate the parsed body
  Prepare release 2.3.0
  Implement ValueResolverInterface
  Leverage `Request::getPayload()` to populate the parsed body of PSR-7 requests
  Add native types where possible
  cs fix
  Prepare the 2.2.0 release
  Bump psr/http-message version
  Drop support for Symfony 4
  Adjustments for PHP CS Fixer 3
  ...
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+6.4
+---
+
+ * Add `RunProcessMessage` and `RunProcessMessageHandler`
+
 5.2.0
 -----
 
diff --git a/Exception/RunProcessFailedException.php b/Exception/RunProcessFailedException.php
@@ -0,0 +1,25 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Process\Exception;
+
+use Symfony\Component\Process\Messenger\RunProcessContext;
+
+/**
+ * @author Kevin Bond <kevinbond@gmail.com>
+ */
+final class RunProcessFailedException extends RuntimeException
+{
+    public function __construct(ProcessFailedException $exception, public readonly RunProcessContext $context)
+    {
+        parent::__construct($exception->getMessage(), $exception->getCode());
+    }
+}
diff --git a/Messenger/RunProcessContext.php b/Messenger/RunProcessContext.php
@@ -0,0 +1,33 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Process\Messenger;
+
+use Symfony\Component\Process\Process;
+
+/**
+ * @author Kevin Bond <kevinbond@gmail.com>
+ */
+final class RunProcessContext extends RunProcessMessage
+{
+    public readonly ?int $exitCode;
+    public readonly ?string $output;
+    public readonly ?string $errorOutput;
+
+    public function __construct(RunProcessMessage $message, Process $process)
+    {
+        parent::__construct($message->command, $message->cwd, $message->env, $message->input, $message->timeout);
+
+        $this->exitCode = $process->getExitCode();
+        $this->output = $process->isOutputDisabled() ? null : $process->getOutput();
+        $this->errorOutput = $process->isOutputDisabled() ? null : $process->getErrorOutput();
+    }
+}
diff --git a/Messenger/RunProcessMessage.php b/Messenger/RunProcessMessage.php
@@ -0,0 +1,32 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Process\Messenger;
+
+/**
+ * @author Kevin Bond <kevinbond@gmail.com>
+ */
+class RunProcessMessage implements \Stringable
+{
+    public function __construct(
+        public readonly array $command,
+        public readonly ?string $cwd = null,
+        public readonly ?array $env = null,
+        public readonly mixed $input = null,
+        public readonly ?float $timeout = 60.0,
+    ) {
+    }
+
+    public function __toString(): string
+    {
+        return \implode(' ', $this->command);
+    }
+}
diff --git a/Messenger/RunProcessMessageHandler.php b/Messenger/RunProcessMessageHandler.php
@@ -0,0 +1,33 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Process\Messenger;
+
+use Symfony\Component\Process\Exception\ProcessFailedException;
+use Symfony\Component\Process\Exception\RunProcessFailedException;
+use Symfony\Component\Process\Process;
+
+/**
+ * @author Kevin Bond <kevinbond@gmail.com>
+ */
+final class RunProcessMessageHandler
+{
+    public function __invoke(RunProcessMessage $message): RunProcessContext
+    {
+        $process = new Process($message->command, $message->cwd, $message->env, $message->input, $message->timeout);
+
+        try {
+            return new RunProcessContext($message, $process->mustRun());
+        } catch (ProcessFailedException $e) {
+            throw new RunProcessFailedException($e, new RunProcessContext($message, $e->getProcess()));
+        }
+    }
+}
diff --git a/Tests/Messenger/RunProcessMessageHandlerTest.php b/Tests/Messenger/RunProcessMessageHandlerTest.php
@@ -0,0 +1,43 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Process\Tests\Messenger;
+
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\Process\Exception\RunProcessFailedException;
+use Symfony\Component\Process\Messenger\RunProcessMessage;
+use Symfony\Component\Process\Messenger\RunProcessMessageHandler;
+
+class RunProcessMessageHandlerTest extends TestCase
+{
+    public function testRunSuccessfulProcess()
+    {
+        $context = (new RunProcessMessageHandler())(new RunProcessMessage(['ls'], cwd: __DIR__));
+
+        $this->assertSame(['ls'], $context->command);
+        $this->assertSame(0, $context->exitCode);
+        $this->assertStringContainsString(basename(__FILE__), $context->output);
+    }
+
+    public function testRunFailedProcess()
+    {
+        try {
+            (new RunProcessMessageHandler())(new RunProcessMessage(['invalid']));
+        } catch (RunProcessFailedException $e) {
+            $this->assertSame(['invalid'], $e->context->command);
+            $this->assertSame(127, $e->context->exitCode);
+
+            return;
+        }
+
+        $this->fail('Exception not thrown');
+    }
+}
