Remove unnecessary empty usages

ostrolucky · ostrolucky · commit 41dce07ca158 · 2024-04-01T13:34:39.000+02:00
diff --git a/Factory/PsrHttpFactory.php b/Factory/PsrHttpFactory.php
@@ -178,7 +178,7 @@ public function createResponse(Response $symfonyResponse): ResponseInterface
 
         $headers = $symfonyResponse->headers->all();
         $cookies = $symfonyResponse->headers->getCookies();
-        if (!empty($cookies)) {
+        if ($cookies) {
             $headers['Set-Cookie'] = [];
 
             foreach ($cookies as $cookie) {
diff --git a/Tests/Fixtures/Uri.php b/Tests/Fixtures/Uri.php
@@ -47,13 +47,13 @@ public function getScheme(): string
 
     public function getAuthority(): string
     {
-        if (empty($this->host)) {
+        if (!$this->host) {
             return '';
         }
 
         $authority = $this->host;
 
-        if (!empty($this->userInfo)) {
+        if ($this->userInfo) {
             $authority = $this->userInfo.'@'.$authority;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -47,13 +47,13 @@ public function getScheme(): string`
`47`	`47`
`48`	`48`	`public function getAuthority(): string`
`49`	`49`	`{`
`50`		`- if (empty($this->host)) {`
	`50`	`+ if (!$this->host) {`
`51`	`51`	`return '';`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`$authority = $this->host;`
`55`	`55`
`56`		`- if (!empty($this->userInfo)) {`
	`56`	`+ if ($this->userInfo) {`
`57`	`57`	`$authority = $this->userInfo.'@'.$authority;`
`58`	`58`	`}`
`59`	`59`