do not use PHPUnit mock objects without configured expectations

xabbuh · xabbuh · commit 078239d7b4d8 · 2026-01-04T13:27:22.000+01:00
diff --git a/Tests/RingCentralTransportTest.php b/Tests/RingCentralTransportTest.php
@@ -12,6 +12,7 @@
 namespace Symfony\Component\Notifier\Bridge\RingCentral\Tests;
 
 use Symfony\Component\HttpClient\MockHttpClient;
+use Symfony\Component\HttpClient\Response\MockResponse;
 use Symfony\Component\Notifier\Bridge\RingCentral\RingCentralOptions;
 use Symfony\Component\Notifier\Bridge\RingCentral\RingCentralTransport;
 use Symfony\Component\Notifier\Exception\InvalidArgumentException;
@@ -60,14 +61,11 @@ public function testInvalidArgumentExceptionIsThrownIfFromIsInvalid(string $from
     public function testNoInvalidArgumentExceptionIsThrownIfFromIsValid(string $from)
     {
         $message = new SmsMessage('+33612345678', 'Hello!');
-        $response = $this->createMock(ResponseInterface::class);
-        $response->expects(self::exactly(2))->method('getStatusCode')->willReturn(200);
-        $response->expects(self::once())->method('getContent')->willReturn(json_encode(['id' => 'foo']));
-        $client = new MockHttpClient(function (string $method, string $url) use ($response): ResponseInterface {
+        $client = new MockHttpClient(function (string $method, string $url): ResponseInterface {
             self::assertSame('POST', $method);
             self::assertSame('https://platform.ringcentral.com/restapi/v1.0/account/~/extension/~/sms', $url);
 
-            return $response;
+            return new MockResponse(json_encode(['id' => 'foo']));
         }
         );
         $transport = $this->createTransport($client, $from);
