[Tests] New iteration of removing $this occurrences in future static data providers

alexandre-daubois · alexandre-daubois · commit 7ef036c74f34 · 2023-01-23T17:58:44.000+01:00
diff --git a/Tests/Authentication/DefaultAuthenticationSuccessHandlerTest.php b/Tests/Authentication/DefaultAuthenticationSuccessHandlerTest.php
@@ -38,14 +38,26 @@ public function testRequestRedirections(Request $request, $options, $redirectedU
         $this->assertSame('http://localhost'.$redirectedUrl, $handler->onAuthenticationSuccess($request, $token)->getTargetUrl());
     }
 
-    public function getRequestRedirections()
+    public function testRequestRedirectionsWithTargetPathInSessions()
     {
         $session = $this->createMock(SessionInterface::class);
         $session->expects($this->once())->method('get')->with('_security.admin.target_path')->willReturn('/admin/dashboard');
         $session->expects($this->once())->method('remove')->with('_security.admin.target_path');
         $requestWithSession = Request::create('/');
         $requestWithSession->setSession($session);
 
+        $urlGenerator = $this->createMock(UrlGeneratorInterface::class);
+        $urlGenerator->expects($this->any())->method('generate')->willReturn('http://localhost/login');
+        $httpUtils = new HttpUtils($urlGenerator);
+        $token = $this->createMock(TokenInterface::class);
+        $handler = new DefaultAuthenticationSuccessHandler($httpUtils);
+        $handler->setFirewallName('admin');
+
+        $this->assertSame('http://localhost/admin/dashboard', $handler->onAuthenticationSuccess($requestWithSession, $token)->getTargetUrl());
+    }
+
+    public static function getRequestRedirections()
+    {
         return [
             'default' => [
                 Request::create('/'),
@@ -72,11 +84,6 @@ public function getRequestRedirections()
                 ['target_path_parameter' => '_target_path[value]'],
                 '/dashboard',
             ],
-            'target path in session' => [
-                $requestWithSession,
-                [],
-                '/admin/dashboard',
-            ],
             'target path as referer' => [
                 Request::create('/', 'GET', [], [], [], ['HTTP_REFERER' => 'http://localhost/dashboard']),
                 ['use_referer' => true],
