security #cve-2019-18887 [HttpKernel] Use constant time comparison in UriSigner (stof)

nicolas-grekas · nicolas-grekas · commit 010213408e61 · 2019-11-12T13:47:53.000+01:00
This PR was merged into the 3.4 branch.
diff --git a/src/Symfony/Component/HttpKernel/UriSigner.php b/src/Symfony/Component/HttpKernel/UriSigner.php
@@ -79,7 +79,7 @@ public function check($uri)
         $hash = $params[$this->parameter];
         unset($params[$this->parameter]);
 
-        return $this->computeHash($this->buildUrl($url, $params)) === $hash;
+        return hash_equals($this->computeHash($this->buildUrl($url, $params)), $hash);
     }
 
     private function computeHash($uri)
diff --git a/src/Symfony/Component/HttpKernel/composer.json b/src/Symfony/Component/HttpKernel/composer.json
@@ -21,6 +21,7 @@
         "symfony/http-foundation": "~3.4.12|~4.0.12|^4.1.1",
         "symfony/debug": "^3.3.3|~4.0",
         "symfony/polyfill-ctype": "~1.8",
+        "symfony/polyfill-php56": "~1.8",
         "psr/log": "~1.0"
     },
     "require-dev": {

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ public function check($uri)`
`79`	`79`	`$hash = $params[$this->parameter];`
`80`	`80`	`unset($params[$this->parameter]);`
`81`	`81`
`82`		`- return $this->computeHash($this->buildUrl($url, $params)) === $hash;`
	`82`	`+ return hash_equals($this->computeHash($this->buildUrl($url, $params)), $hash);`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`private function computeHash($uri)`