implemented reviewer's suggestions

przemyslaw-bogusz · przemyslaw-bogusz · commit 018f91a62fbb · 2019-01-15T00:44:24.000+01:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/EventListener/SuggestMissingPackageSubscriber.php b/src/Symfony/Bundle/FrameworkBundle/EventListener/SuggestMissingPackageSubscriber.php
@@ -24,7 +24,12 @@
  */
 final class SuggestMissingPackageSubscriber implements EventSubscriberInterface
 {
-    const SUGGESTED_PACKAGES = [
+    /**
+     * Mappings between namespaces of Symfony commands and packages required to run these commands.
+     *
+     * @var array $suggestedPackages
+     */
+    private static $suggestedPackages = [
         'doctrine' => [
             'Doctrine ORM',
             'symfony/orm-pack',
@@ -49,10 +54,10 @@ public function onConsoleError(ConsoleErrorEvent $event)
             if (null !== $event->getInput()->getFirstArgument()) {
                 $namespace = explode(':', $event->getInput()->getFirstArgument())[0];
 
-                if (isset(self::SUGGESTED_PACKAGES[$namespace])) {
-                    $suggestion = self::SUGGESTED_PACKAGES[$namespace];
+                if (isset(self::$suggestedPackages[$namespace])) {
+                    $suggestion = self::$suggestedPackages[$namespace];
                     $message = sprintf("It seems that you are trying to run a command from '%s' bundle/package, but you do not have it installed. You may try installing the missing bundle/package by running:\n\n    composer require %s", $suggestion[0], $suggestion[1]);
-                    throw new NamespaceNotFoundException($message);
+                    $event->setError(new NamespaceNotFoundException($message));
                 }
             }
         }
