Support for SwitchUserToken instances serialized with 4.4/5.1.

derrabus · derrabus · commit 01bea3c0852a · 2020-11-27T02:03:01.000+01:00
diff --git a/src/Symfony/Component/Security/Core/Authentication/Token/SwitchUserToken.php b/src/Symfony/Component/Security/Core/Authentication/Token/SwitchUserToken.php
@@ -59,7 +59,12 @@ public function __serialize(): array
      */
     public function __unserialize(array $data): void
     {
-        [$this->originalToken, $this->originatedFromUri, $parentData] = $data;
+        if (3 > \count($data)) {
+            // Support for tokens serialized with version 5.1 or lower of symfony/security-core.
+            [$this->originalToken, $parentData] = $data;
+        } else {
+            [$this->originalToken, $this->originatedFromUri, $parentData] = $data;
+        }
         $parentData = \is_array($parentData) ? $parentData : unserialize($parentData);
         parent::__unserialize($parentData);
     }
diff --git a/src/Symfony/Component/Security/Core/Tests/Authentication/Token/Fixtures/switch-user-token-4.4.txt b/src/Symfony/Component/Security/Core/Tests/Authentication/Token/Fixtures/switch-user-token-4.4.txt
diff --git a/src/Symfony/Component/Security/Core/Tests/Authentication/Token/SwitchUserTokenTest.php b/src/Symfony/Component/Security/Core/Tests/Authentication/Token/SwitchUserTokenTest.php
@@ -84,4 +84,18 @@ public function testSerializeNullImpersonateUrl()
 
         $this->assertNull($unserializedToken->getOriginatedFromUri());
     }
+
+    public function testUnserializeOldToken()
+    {
+        /** @var SwitchUserToken $token */
+        $token = unserialize(file_get_contents(__DIR__.'/Fixtures/switch-user-token-4.4.txt'));
+
+        self::assertInstanceOf(SwitchUserToken::class, $token);
+        self::assertInstanceOf(UsernamePasswordToken::class, $token->getOriginalToken());
+        self::assertSame('john', $token->getUsername());
+        self::assertSame(['foo' => 'bar'], $token->getCredentials());
+        self::assertSame('main', $token->getFirewallName());
+        self::assertEquals(['ROLE_USER'], $token->getRoleNames());
+        self::assertNull($token->getOriginatedFromUri());
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,12 @@ public function __serialize(): array`
`59`	`59`	`*/`
`60`	`60`	`public function __unserialize(array $data): void`
`61`	`61`	`{`
`62`		`- [$this->originalToken, $this->originatedFromUri, $parentData] = $data;`
	`62`	`+ if (3 > \count($data)) {`
	`63`	`+ // Support for tokens serialized with version 5.1 or lower of symfony/security-core.`
	`64`	`+ [$this->originalToken, $parentData] = $data;`
	`65`	`+ } else {`
	`66`	`+ [$this->originalToken, $this->originatedFromUri, $parentData] = $data;`
	`67`	`+ }`
`63`	`68`	`$parentData = \is_array($parentData) ? $parentData : unserialize($parentData);`
`64`	`69`	`parent::__unserialize($parentData);`
`65`	`70`	`}`