[Form] Fix a BC break in the entity

jakzal · jakzal · commit 03642b8ffeaf · 2015-07-14T19:21:52.000+01:00
diff --git a/src/Symfony/Bridge/Doctrine/Form/Type/DoctrineType.php b/src/Symfony/Bridge/Doctrine/Form/Type/DoctrineType.php
@@ -87,7 +87,7 @@ public static function createChoiceLabel($choice)
      */
     public static function createChoiceName($choice, $key, $value)
     {
-        return (string) $value;
+        return str_replace('-', '_', (string) $value);
     }
 
     /**
diff --git a/src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypeTest.php b/src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypeTest.php
@@ -495,6 +495,31 @@ public function testSubmitMultipleExpanded()
         $this->assertSame('3', $field['3']->getViewData());
     }
 
+    public function testSubmitMultipleExpandedWithNegativeIntegerId()
+    {
+        $entity1 = new SingleIntIdEntity(-1, 'Foo');
+        $entity2 = new SingleIntIdEntity(2, 'Bar');
+
+        $this->persist(array($entity1, $entity2));
+
+        $field = $this->factory->createNamed('name', 'entity', null, array(
+            'multiple' => true,
+            'expanded' => true,
+            'em' => 'default',
+            'class' => self::SINGLE_IDENT_CLASS,
+            'choice_label' => 'name',
+        ));
+
+        $field->submit(array('-1'));
+
+        $expected = new ArrayCollection(array($entity1));
+
+        $this->assertTrue($field->isSynchronized());
+        $this->assertEquals($expected, $field->getData());
+        $this->assertTrue($field['_1']->getData());
+        $this->assertFalse($field['2']->getData());
+    }
+
     public function testOverrideChoices()
     {
         $entity1 = new SingleIntIdEntity(1, 'Foo');

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ public static function createChoiceLabel($choice)`
`87`	`87`	`*/`
`88`	`88`	`public static function createChoiceName($choice, $key, $value)`
`89`	`89`	`{`
`90`		`- return (string) $value;`
	`90`	`+ return str_replace('-', '_', (string) $value);`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`/**`