bug #54146 [HttpClient] Preserve float in JsonMockResponse (Jibbarth)

derrabus · derrabus · commit 05233000b579 · 2024-03-05T09:49:01.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [HttpClient] Preserve float in JsonMockResponse | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Issues | Fix #...  | License | MIT Hello, I am mocking an API Response that can send float in values : ``` { "values": 1.0 } ``` Converting this to a php array and giving it to JsonMockResponse return me an int after, because the missing json_encode flag to keep zero fraction, and leds to issue when I want to deserialize it into a float property. In my mind it's a bugfix, but if it's considered as a new feature, I can target 7.1. Commits ------- 4d120b8 [HttpClient] Preserve float in JsonMockResponse
diff --git a/src/Symfony/Component/HttpClient/Response/JsonMockResponse.php b/src/Symfony/Component/HttpClient/Response/JsonMockResponse.php
@@ -21,7 +21,7 @@ class JsonMockResponse extends MockResponse
     public function __construct(mixed $body = [], array $info = [])
     {
         try {
-            $json = json_encode($body, \JSON_THROW_ON_ERROR);
+            $json = json_encode($body, \JSON_THROW_ON_ERROR | \JSON_PRESERVE_ZERO_FRACTION);
         } catch (\JsonException $e) {
             throw new InvalidArgumentException('JSON encoding failed: '.$e->getMessage(), $e->getCode(), $e);
         }
diff --git a/src/Symfony/Component/HttpClient/Tests/Response/JsonMockResponseTest.php b/src/Symfony/Component/HttpClient/Tests/Response/JsonMockResponseTest.php
@@ -59,6 +59,22 @@ public function testJsonEncodeString()
         $this->assertSame('application/json', $response->getHeaders()['content-type'][0]);
     }
 
+    public function testJsonEncodeFloat()
+    {
+        $client = new MockHttpClient(new JsonMockResponse([
+            'foo' => 1.23,
+            'ccc' => 1.0,
+            'baz' => 10.,
+        ]));
+        $response = $client->request('GET', 'https://symfony.com');
+
+        $this->assertSame([
+            'foo' => 1.23,
+            'ccc' => 1.,
+            'baz' => 10.,
+        ], $response->toArray());
+    }
+
     /**
      * @dataProvider responseHeadersProvider
      */

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ class JsonMockResponse extends MockResponse`
`21`	`21`	`public function __construct(mixed $body = [], array $info = [])`
`22`	`22`	`{`
`23`	`23`	`try {`
`24`		`- $json = json_encode($body, \JSON_THROW_ON_ERROR);`
	`24`	`+ $json = json_encode($body, \JSON_THROW_ON_ERROR \| \JSON_PRESERVE_ZERO_FRACTION);`
`25`	`25`	`} catch (\JsonException $e) {`
`26`	`26`	`throw new InvalidArgumentException('JSON encoding failed: '.$e->getMessage(), $e->getCode(), $e);`
`27`	`27`	`}`